Closed
Bug 982723
Opened 11 years ago
Closed 11 years ago
[DSDS][Dialer] Change uses of mozMobileConnections to mozIccManager
Categories
(Firefox OS Graveyard :: Gaia::Dialer, defect)
Firefox OS Graveyard
Gaia::Dialer
Tracking
(Not tracked)
RESOLVED
FIXED
1.4 S3 (14mar)
People
(Reporter: drs, Assigned: drs)
References
Details
(Whiteboard: [ucid:, 1.4, ft:comms])
Attachments
(1 file)
We made a mistake in bug 946866 and used mozMobileConnections everywhere instead of mozIccManager, and we need to switch it over.
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → drs+bugzilla
Blocks: 1.4-comms-committed, b2g-dsds-1.4
Depends on: 946866
Whiteboard: [ucid:, 1.4, ft:comms]
Target Milestone: --- → 1.4 S3 (14mar)
|
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8390085 -
Flags: review?(anthony)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 8390085 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/17137
We don't need to keep the mozMobileConnections check in call_button. In call button, we want to know if the device has several SIMs present or not. Also, the first call to navigator.mozIccManager.iccIds is costly but the next ones are almost no-ops (I forgot to mention that earlier).
With that change, we can remove the mock for mozMobileConnection in tests and the extra new test.
Also, we need the same change in SimPicker.
Attachment #8390085 -
Flags: review?(anthony)
|
|
Assignee | |
Comment 3•11 years ago
|
||
Comment on attachment 8390085 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/17137
PR updated.
Attachment #8390085 -
Flags: review?(anthony)
|
|
Assignee | |
Comment 4•11 years ago
|
||
(In reply to Doug Sherk (:drs) from comment #3)
> Comment on attachment 8390085 [details]
> Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/17137
>
> PR updated.
And again.
|
|
||
Comment 5•11 years ago
|
||
Comment on attachment 8390085 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/17137
r+ with a small nit.
Attachment #8390085 -
Flags: review?(anthony) → review+
|
|
Assignee | |
Comment 6•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•