Closed
Bug 983066
Opened 11 years ago
Closed 11 years ago
assertion failure: Samples missing: 'startTicks == TimeToTicksRoundUp(inputTrackRate, outputStart)' in AudioNodeExternalInputStream.cpp
Categories
(Core :: Web Audio, defect, P2)
Tracking
()
RESOLVED
FIXED
mozilla31
People
(Reporter: karlt, Assigned: karlt)
References
Details
Attachments
(1 file)
|
(deleted),
patch
|
padenot
:
review+
|
Details | Diff | Splinter Review |
STR
1. Load attachment 831234 [details]
###!!! ASSERTION: Samples missing: 'startTicks == TimeToTicksRoundUp(inputTrackRate, outputStart)', file /home/karl/moz/dev/content/media/AudioNodeExternalInputStream.cpp, line 379
This is from adding more null samples than expected when the track has ended and inputStartTicks > inputTrackEndPoint at
http://hg.mozilla.org/mozilla-central/annotate/c12c92db5588/content/media/AudioNodeExternalInputStream.cpp#l415
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #8390983 -
Flags: review?(paul)
|
||
Updated•11 years ago
|
Attachment #8390983 -
Flags: review?(paul) → review+
|
||
Comment 2•11 years ago
|
||
What's the status of this bug.
|
||
Comment 3•11 years ago
|
||
Hi Karl, To Martin's question in Comment 2, are you ready to land now that you have your r+ from Paul? Thanks.
Flags: needinfo?(karlt)
|
|
Assignee | |
Comment 4•11 years ago
|
||
Please feel free to land this if it is blocking anything.
I was delaying landing this, waiting for bug 818822, because the old code may have unintentionally made bug 983062 slightly less significant sometimes.
But I expect the effects of bug 983062 would usually not be noticeable, due to being at the end of the audio, which usually fades out.
Flags: needinfo?(karlt)
|
|
Assignee | |
Comment 5•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/b7036a21d1a4
(In reply to Karl Tomlinson (:karlt) from comment #0)
> STR
> 1. Load attachment 831234 [details]
I meant attachment 831235 [details].
Flags: in-testsuite+
|
||
Comment 6•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in
before you can comment on or make changes to this bug.
Description
•