Running test_sync.js sometimes timeout after syncing. Not sure if that is a tps issue or a bug in Firefox. This needs closer inspection. CROSSWEAVE INFO: Setting client credentials. CROSSWEAVE INFO: ----------event observed: fxaccounts:onlogin CROSSWEAVE INFO: Waiting for weave:service:setup-complete... CROSSWEAVE INFO: ----------event observed: weave:service:setup-complete CROSSWEAVE INFO: ----------event observed: weave:engine:start-tracking CROSSWEAVE INFO: weave:service:setup-complete observed! CROSSWEAVE INFO: ----------event observed: weave:service:sync:finish CROSSWEAVE INFO: starting action: [null,{"menu":[{"uri":"http://www.google.com","loadInSidebar":true,"tags":["google","computers","internet","www"],"changes":{"title":"Google","loadInSidebar":false,"tags":["google","computers","misc"]}},{"uri":"http://bugzilla.mozilla.org/show_bug.cgi?id=%s","title":"Bugzilla","keyword":"bz","changes":{"keyword":"bugzilla"}},{"folder":"foldera"},{"uri":"http://www.mozilla.com"},{"separator":true},{"folder":"folderb"}],"menu/foldera":[{"uri":"http://www.yahoo.com","title":"testing Yahoo","changes":{"location":"menu/folderb"}},{"uri":"http://www.cnn.com","description":"This is a description of the site a at www.cnn.com","changes":{"uri":"http://money.cnn.com","description":"new description"}},{"livemark":"Livemark1","feedUri":"http://rss.wunderground.com/blog/JeffMasters/rss.xml","siteUri":"http://www.wunderground.com/blog/JeffMasters/show.html","changes":{"livemark":"LivemarkOne"}}],"menu/folderb":[{"uri":"http://www.apple.com","tags":["apple","mac"],"changes":{"uri":"http://www.apple.com/iphone/","title":"iPhone","location":"menu","position":"Google","tags":[]}}],"toolbar":[{"uri":"place:queryType=0&sort=8&maxResults=10&beginTimeRef=1&beginTime=0","title":"Visited Today"}]}] CROSSWEAVE INFO: executing action ADD on bookmark {"uri":"http://www.google.com","loadInSidebar":true,"tags":["google","computers","internet","www"],"changes":{"title":"Google","loadInSidebar":false,"tags":["google","computers","misc"]},"location":"menu"} CROSSWEAVE INFO: executing action ADD on bookmark {"uri":"http://bugzilla.mozilla.org/show_bug.cgi?id=%s","title":"Bugzilla","keyword":"bz","changes":{"keyword":"bugzilla"},"location":"menu","last_item_pos":4} CROSSWEAVE INFO: executing action ADD on bookmark {"folder":"foldera","location":"menu","last_item_pos":5} CROSSWEAVE INFO: executing action ADD on bookmark {"uri":"http://www.mozilla.com","location":"menu","last_item_pos":6} CROSSWEAVE INFO: executing action ADD on bookmark {"separator":true,"location":"menu","last_item_pos":7} CROSSWEAVE INFO: executing action ADD on bookmark {"folder":"folderb","location":"menu","last_item_pos":8} CROSSWEAVE INFO: executing action ADD on bookmark {"uri":"http://www.yahoo.com","title":"testing Yahoo","changes":{"location":"menu/folderb"},"location":"menu/foldera"} CROSSWEAVE INFO: ----------event observed: weave:service:sync:finish TEST-UNEXPECTED-FAIL | test_sync.js | test did not complete phase1: unknown phase2: unknown phase3: unknown phase4: unknown Test Summary

When I quit Firefox when it hangs the following stack is visible: CROSSWEAVE ERROR: [phase1] Exception caught: App. Quitting Stack trace: checkAppReady/onQuitApplication/Async.checkAppReady()@resource://services-common/async.js:123 < waitForSyncCallback()@resource://services-common/async.js:98 < makeSpinningCallback/callback.wait()@resource://services-common/async.js:141 < TPS_Bookmarks__DumpBookmarks()@resource://tps/modules/bookmarks.jsm:43 < TPS.HandleBookmarks()@resource://tps/tps.jsm:458 < Bookmarks__add()@resource://tps/tps.jsm:896 < TPS.RunNextTestAction()@resource://tps/tps.jsm:505 < TPS.RunNextTestAction()@resource://tps/tps.jsm:517 < <file:unknown>

Ok, so this is not the test but the framework. Due to my refactoring in bug 966434 I missed to rename an instance of CI into Ci in bookmarks.jsm. Sadly this error doesn't show up and TPS.HandleBookmarks() waits forever to continue. We should really log every failure! I will take care of this once the refactoring has been finished.

I think this works as expected now.