Load a large page, and while it's still loading, try to use the findbar. The text keeps getting reset until the page is completely loaded.

This happens because of these lines in findbar's onFindResult, added in bug 326743: http://hg.mozilla.org/mozilla-central/rev/ce1491d00b42#l1.109 When e10s is enabled and you type faster than find results are returned from the child process, this causes old search strings from results to overwrite newer ones you've typed.

Comment on attachment 8468571 [details] [diff] [review] Bug 983189: No longer update the findbar when results are received from the child Review of attachment 8468571 [details] [diff] [review]: ----------------------------------------------------------------- Please be aware that this patch doesn't apply cleanly on m-c. But looking past that, I can't see any side-effects to removing this. In fact, I'm very happy to be rid of this hack!! Thanks Alex :)

I messed up my working branch for this bug. Sorry about this. This patch should apply.

(In reply to atifrea from comment #5) > I messed up my working branch for this bug. Sorry about this. This patch > should apply. I understood that already, hence my r+ with that in mind. In the future, you don't really need to re-request review, just post a new patch and set the r+ flag yourself. Bonus points when you update the commit message in there to reflect this status (add 'r=mikedeboer', for example) and mention 'Carrying over r=mikedeboer' in the bug comment. Thanks for picking this up. Do you want me to land this puppy?

Thanks for the advice. I will do that in the future. And it would be great if you could land it, yes. Thank you!

Alex, can you upload a patch that I can push? This basically means the current patch with metadata, like your user info and a commit message.

Done.

Pushed to fx-team as: https://hg.mozilla.org/integration/fx-team/rev/38a4a22757f9 Alex, please take a good look at this patch; it contains all the correct metadata in a format that is friendly for people to read as they wade through changelogs and/ or commit history of findbar.xml. It's important, obligatory even, to mention 1) the bug number, 2) the granted flag(s) with the name(s) of the granter (like 'r=atifrea, ui-r=shorlander, sr=bz', etc.) 3) a complete description of what the patch changed and its intended purpose. We're using Mercurial as VCS at Mozilla. This might not be your own personal preference and we indeed offer the option to develop using a Git workflow, but in the end patches must be applied to the Mercurial tree. In other words: please upload patches in a format Mercurial can use. Also, when you upload a new patch and carry over flags that were already granted before, please mention that in a bug comment, like 'New patch with nits fixed, carrying over r=atifrea.' or something similar. This way ppl who are following the progress of this bug can keep track of the progress more easily. Last, but certainly not least, thanks for fixing this!

I was able to reproduce this issue on Nightly 34.0a1 (2014-08-05) using Windows 7 x64 and Mac OSX 10.8.5. Verified fixed on Latest Nightly 36.0a1 (2014-11-17) using Windows 7 x64, Ubuntu 12.04 x32 and Mac OSX 10.8.5