Christopher Van Wiemeersch [:cvan] Assignee
	Description • 11 years ago

This bug is two fold:

Desktop:
1. On desktop load https://marketplace.firefox.com/search?q=youtube at full width
2. Notice 6,386.22 KB (6.24 MB!!!!) gets loaded (126 requests, 6.39s): http://cl.ly/image/3P0L3b2M3O1X
3. Click the condensed view toggle: http://cl.ly/image/2O1Y1W303B1Y
4. Notice it doesn't persist when you refresh (bug!): http://cl.ly/image/2z2U062F3L12

Mobile:
1. Fake your User-Agent as Firefox OS ("Mozilla/5.0 (Mobile; rv:18.0) Gecko/18.0 Firefox/18.0"). Proof: http://cl.ly/image/1F242i0y3h3S
2. On desktop with responsive mode for 320x480 load https://marketplace.firefox.com/search?q=youtube
3. Make sure the condensed view is toggle.
4. Notice 6,056.66 KB (5.91 MB!!!!) gets loaded (118 requests, 4.40s): http://cl.ly/image/2K2L1k1u3p0Q
5. Gasp in awe that the screenshots are still getting loaded on mobile as Firefox OS, even though they're not visible on screen (bug!).

	Christopher Van Wiemeersch [:cvan] Assignee
	Comment 1 • 11 years ago

Well, ladies and gentlemen, hidden `<img>`s get loaded in every browser:

    http://jsbin.com/valevose/1/

I have a workaround coming. But, omg. I seem to recall running into this issue a few years ago.

	Christopher Van Wiemeersch [:cvan] Assignee
	Comment 2 • 11 years ago

And for the skeptics out there, same thing if you `display:none` the parent element:

    http://jsbin.com/yozogeme/1/

	Christopher Van Wiemeersch [:cvan] Assignee
	Comment 3 • 11 years ago

https://github.com/mozilla/fireplace/commit/0d5c1b73

	Christopher Van Wiemeersch [:cvan] Assignee
	Comment 4 • 11 years ago

This would be nice to get cherrypicked for Tuesday's tag. If people could kindly test this based on my STR in comment 0, that would be fantastic.

	Iulian Timis
	Comment 5 • 11 years ago

Verified as fixed in https://marketplace-dev.allizom.org/search?q=youtube on FF30 (Win 7)
In the console it shows that images are not loaded when in compact view.
Postfix screencast:
Desktop http://screencast.com/t/CaxBVSz1UKm
Mobile http://screencast.com/t/AcaVlig9Pw
Closing bug.

	Christopher Van Wiemeersch [:cvan] Assignee
	Comment 6 • 10 years ago

This was not working on the detail page <https://marketplace-dev.allizom.org/app/youtube-1?src=search>:
https://github.com/mozilla/fireplace/commit/e102e2a

	Iulian Timis
	Comment 7 • 10 years ago

Could you please add STR on how can I verify the scenario from comment 6? Thank you

	Christopher Van Wiemeersch [:cvan] Assignee
	Comment 9 • 10 years ago

(In reply to Iulian Timis from comment #7)
> Could you please add STR on how can I verify the scenario from comment 6?
> Thank you

It's working now. No worries.