Closed Bug 983614 Opened 11 years ago Closed 11 years ago

Output of newly styled DOM nodes in console buggy.

Categories

(DevTools :: Console, defect)

defect
Not set
normal

Tracking

(firefox30 fixed, firefox31 fixed)

RESOLVED FIXED
Firefox 31
Tracking Status
firefox30 --- fixed
firefox31 --- fixed

People

(Reporter: danemacmillan, Assigned: pbro)

References

Details

Attachments

(1 file)

This bug is related to bug 682033. That bug enhanced the output of nodes in the console. It works great, with the exception of the output you see in the image: http://i.imgur.com/eHYZMH1.png There are an excess of periods following one of the class names on the body. For the meantime I seem only to reproduce it on the bugzilla pages. I'm sure it can be reproduced elsewhere. Maybe it's the colon in the class name that is affecting the output.
Patrick: it seems we dont cleanup className before split(' ').
Status: UNCONFIRMED → NEW
Depends on: 757866
Ever confirmed: true
Assignee: nobody → pbrosset
Instead of splitting on " ", now splitting on regexp \s+ Added a new DOM element in one of the test files to ensure this doesn't happen again.
Attachment #8393405 - Flags: review?(mihai.sucan)
Comment on attachment 8393405 [details] [diff] [review] bug983614-cleanup-classnames-in-domnode-console-output v1.patch Review of attachment 8393405 [details] [diff] [review]: ----------------------------------------------------------------- Thanks! Do we want this fix in aurora? If you think we should get this in aurora, please also ask for approval.
Attachment #8393405 - Flags: review?(mihai.sucan) → review+
Keywords: checkin-needed
Comment on attachment 8393405 [details] [diff] [review] bug983614-cleanup-classnames-in-domnode-console-output v1.patch [Approval Request Comment] Bug caused by (feature/regressing bug #): This bug is a follow-up of bug 757866 which is a new feature that made it to Aurora 30 last week. This new feature enriches the web console output for DOM Nodes. User impact if declined: If declined, DOM nodes returned by querySelectorAll displayed in the web console output may not be very pretty in some cases: there may be too many dots between classnames as shown in the screenshot attached. Testing completed (on m-c, etc.): new bc mochitest added, ongoing try build: https://tbpl.mozilla.org/?tree=Try&rev=6a3451414b21 But not yet landed in m-c. Risk to taking this patch (and alternatives if risky): this patch is only changes a `className.split(" ")` into `className.split(/\s+/g)` and only concern DOMNodes being output into the webconsole (when part of NodeList only), so the potential impacts of this patch are very very limited. String or IDL/UUID changes made by this patch: None
Attachment #8393405 - Flags: approval-mozilla-aurora?
I was a bit too quick in asking for check-in, the try build isn't even finished ... https://tbpl.mozilla.org/?tree=Try&rev=6a3451414b21
Keywords: checkin-needed
Green try build and R+ Fixed in fx-team: https://hg.mozilla.org/integration/fx-team/rev/7cfac9ff3b02
Whiteboard: [fixed-in-fx-team]
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 31
Attachment #8393405 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Looks like this landed with tests. Please correct if I am mistaken.
Flags: in-testsuite+
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: