Closed Bug 984327 Opened 11 years ago Closed 11 years ago

B2G RIL: dun apn type is not included in isNetworkTypeSecondaryMobile(...)

Categories

(Firefox OS Graveyard :: RIL, defect)

Product:
Firefox OS Graveyard
Component:
RIL
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:1.4+, firefox29 wontfix, firefox30 fixed, firefox31 fixed, b2g-v1.4 fixed, b2g-v2.0 fixed)

Status:
RESOLVED FIXED
Milestone:
1.4 S4 (28mar)
Project Flags:
blocking-b2g 1.4+
Tracking Flags:
Tracking Status
firefox29 --- wontfix
firefox30 --- fixed
firefox31 --- fixed
b2g-v1.4 --- fixed
b2g-v2.0 --- fixed

People

(Reporter: jessica, Assigned: jessica)

References

Details

Attachments

(2 files, 3 obsolete files)

Part 1: include dun apn type in isNetworkTypeSecondaryMobile(...) and elsewhere. (final)
(deleted), patch
jessica
: review+
Details | Diff | Splinter Review
Part 2: modify test cases for dun. (final)
(deleted), patch
jessica
: review+
Details | Diff | Splinter Review
I think this was left behind while rebasing. :(
Will also add dun test in test_data_connection.js.
It is a 1.4+ issue.
blocking-b2g: --- → 1.4+
Depends on: 960865
Attached patch Part 2: modify test cases for dun. (obsolete) (deleted) — — Splinter Review
Comment on attachment 8392699 [details] [diff] [review] Part 1: include dun apn type in isNetworkTypeSecondaryMobile(...) and elsewhere. Sorry for missing these... :(
Attachment #8392699 - Flags: review?(vyang)
Attachment #8392700 - Flags: review?(vyang)
Attachment #8392699 - Flags: review?(vyang) → review+
Attachment #8392700 - Flags: review?(vyang) → review+
Add r=vicamo.
Attachment #8392700 - Attachment is obsolete: true
Attachment #8393275 - Flags: review+
Ready to land on master, but there is still no official announcement for the process of uplifting to 1.4 branch.
Keywords: checkin-needed
(In reply to Jessica Jong [:jjong] [:jessica] from comment #10) > Ready to land on master, but there is still no official announcement for the > process of uplifting to 1.4 branch. Sure there is, see dev-b2g (or go directly to the source - https://wiki.mozilla.org/Release_Management/B2G_Landing#v1.4.0).
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: