Closed
Bug 984486
Opened 11 years ago
Closed 11 years ago
expect "email" to be primary key for FxA data returned from Gecko, falling back to "accountId"
Categories
(Firefox OS Graveyard :: FxA, defect)
Tracking
(b2g-v2.0 fixed)
RESOLVED
FIXED
2.0 S1 (9may)
| Tracking | Status | |
|---|---|---|
| b2g-v2.0 | --- | fixed |
People
(Reporter: spenrose, Assigned: jhirsch)
References
Details
Attachments
(1 file)
Per https://bugzilla.mozilla.org/show_bug.cgi?id=981210#c3, take one step towards unifying the FxA data to be keyed on "email" by editing FxAccountsIACHelper and friends to look for email and fall back to accountId. Once Gaia can handle either, we can land 981210 to use only email, and then we can remove the fallback logic. Jared LMK if you'd rather I take this.
|
Assignee | |
Comment 1•11 years ago
|
||
Right now, Settings can handle either:
menu item code: https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/js/firefox_accounts/menu.js#L30-L32
panel code: https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/js/firefox_accounts/panel.js#L58-L60
But System cannot:
https://github.com/mozilla-b2g/gaia/blob/master/apps/system/fxa/js/fxam_server_request.js#L24
Fixing this presently, I'll get a PR out.
|
|
Assignee | |
Comment 2•11 years ago
|
||
Also I don't see any reference to accountId anywhere inside the FTU app (apps/communications), so I think this system app is the only spot affected.
|
|
Assignee | |
Comment 3•11 years ago
|
||
|
|
Assignee | |
Comment 4•11 years ago
|
||
Comment on attachment 8403693 [details]
Github PR 18093
ferjm - mind taking a look? This change allows 'email' or 'accountId' as the response within the system app. Travis is green.
Attachment #8403693 -
Flags: review?(ferjmoreno)
|
||
Updated•11 years ago
|
Attachment #8403693 -
Flags: review?(ferjmoreno) → review+
|
|
Assignee | |
Updated•11 years ago
|
|
|
Assignee | |
Comment 5•11 years ago
|
||
Status: NEW → RESOLVED
Closed: 11 years ago
status-b2g-v2.0:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 2.0 S1 (9may)
You need to log in
before you can comment on or make changes to this bug.
Description
•