Closed
Bug 984497
Opened 11 years ago
Closed 11 years ago
Use SpecialPowers more and change SpecialPower usage to deal with Window on WebIDL bindings
Categories
(Core :: General, defect)
Core
General
Tracking
()
RESOLVED
FIXED
mozilla31
People
(Reporter: peterv, Assigned: peterv)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #8392341 -
Flags: review?(bzbarsky)
|
||
Comment 1•11 years ago
|
||
Comment on attachment 8392341 [details] [diff] [review]
v1
> +++ b/content/media/webspeech/synth/test/common.js
This change worries me. Reloading a test in the test harness seems like it would do weird stuff.
We should probably instead run those tests in a subframe that's not loaded until a pushPrefEnv for the pref finishes.
>+++ b/dom/tests/mochitest/bugs/test_bug397571.html
Why can this not use SpecialPowers.DOMWindowUtils? Document, please.
>+++ b/js/xpconnect/tests/mochitest/test_bug870423.html
Why is this change ok? What in this patch makes the instanceof there work?
The rest looks good, but r- for the webspeech bits...
Attachment #8392341 -
Flags: review?(bzbarsky) → review-
|
Assignee | |
Comment 2•11 years ago
|
||
(In reply to Boris Zbarsky [:bz] from comment #1)
> >+++ b/dom/tests/mochitest/bugs/test_bug397571.html
>
> Why can this not use SpecialPowers.DOMWindowUtils? Document, please.
It actually can.
> >+++ b/js/xpconnect/tests/mochitest/test_bug870423.html
>
> Why is this change ok? What in this patch makes the instanceof there work?
It's not, it ended up in the wrong patch.
|
|
Assignee | |
Comment 3•11 years ago
|
||
Attachment #8392341 -
Attachment is obsolete: true
Attachment #8400087 -
Flags: review?(bzbarsky)
|
|
||
Comment 4•11 years ago
|
||
Comment on attachment 8400087 [details] [diff] [review]
v1.1
r=me
Attachment #8400087 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 5•11 years ago
|
||
|
|
Assignee | |
Comment 6•11 years ago
|
||
BTW, had to remove a part of js/xpconnect/tests/chrome/test_doublewrappedcompartments.xul, Bobby approved that earlier but I forgot to integrate it in this patch.
|
||
Comment 7•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in
before you can comment on or make changes to this bug.
Description
•