Closed
Bug 984740
Opened 11 years ago
Closed 11 years ago
When calling notifyChange, don't request an upload sync if the caller is Sync
Categories
(Firefox for Android Graveyard :: Data Providers, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 31
People
(Reporter: rnewman, Assigned: rnewman)
References
Details
Attachments
(1 file)
(deleted),
patch
|
nalexander
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Updated•11 years ago
|
Summary: When calling notifyChange, don't request an upload sync if the caller is sync → When calling notifyChange, don't request an upload sync if the caller is Sync
Assignee | ||
Comment 1•11 years ago
|
||
Assignee | ||
Comment 2•11 years ago
|
||
Comment on attachment 8392678 [details] [diff] [review] When calling notifyChange, don't request an upload sync if the caller is Sync. Review of attachment 8392678 [details] [diff] [review]: ----------------------------------------------------------------- A trivial -- if repetitive -- fix. isCallerSync is copypasta'ed from TransactionalProvider, in the hope of future refactorings. I elected to use a descriptive final variable rather than inlining the call-with-not, because boolean arguments are the devil. I haven't tested this yet, but this should entirely eliminate the immediate double-bounce syncs that we've been seeing for two years.
Attachment #8392678 -
Flags: review?(nalexander)
Comment 3•11 years ago
|
||
Comment on attachment 8392678 [details] [diff] [review] When calling notifyChange, don't request an upload sync if the caller is Sync. Review of attachment 8392678 [details] [diff] [review]: ----------------------------------------------------------------- lgtm. Consider factoring out a local |maybeNotifyChange(url)| that does the Sync check? Hard to prevent future callers missing that and instead calling the ContentResolver's |notifyChange|.
Attachment #8392678 -
Flags: review?(nalexander) → review+
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/9d2991a00b4d
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 31
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•