Anthony Ricaud (:rik) Reporter
	Description • 10 years ago

STR on a Peak with edge gestures activated:
1) Go to Settings>Display
2) Tap the checkbox for Adjust automatically

Actual:
It opens the wallpaper selection menu

Expected:
Adjust automatically is toggled

If you disable edge gestures, it works as expected. If you tap the adjust automatically line, it works as expected.

	Anthony Ricaud (:rik) Reporter
	Comment 1 • 10 years ago

It also prevents index scrolling on the alphabet in the Contacts app.

	Anthony Ricaud (:rik) Reporter
	Comment 2 • 10 years ago

I believe this is also making the send button in the SMS app very hard to tap when the keyboard is opened.

	Jason Smith [:jsmith]
	Comment 3 • 10 years ago

Can we get a video showing the bug here on the latest trunk?

	Anthony Ricaud (:rik) Reporter
	Comment 4 • 10 years ago

For QA, this only happens on hidpi devices. (I updated the title a bit late)

	Jason Smith [:jsmith]
	Comment 6 • 10 years ago

Dupe clarifies this is happening on our reference implementation.

	Jason Smith [:jsmith]
	Comment 7 • 10 years ago

Also - this is not a feature implementation piece, this is classified as a regression from turning on edge gestures.

	Etienne Segonzac (:etienne)
	Comment 8 • 10 years ago

IIRC this is a APZC issue, we might even have a dup.

	Kartikaya Gupta (email:kats@mozilla.staktrace.com)
	Comment 9 • 10 years ago

See https://bugzilla.mozilla.org/show_bug.cgi?id=1010421#c3

	Diego Marcos [:dmarcos]
	Comment 12 • 10 years ago

Any ETA for this? Zoom, On screen UI and touch to focus are affected by this in the camera app.

	howie [:howie]
	Comment 13 • 10 years ago

Hi Gregor, it belongs to system fe, can you do the triage?

	Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please) Assignee
	Comment 14 • 10 years ago

I didn't tried the patch but Etienne told me that it fix the issue for him on the Nexus 4.

	Kartikaya Gupta (email:kats@mozilla.staktrace.com)
	Comment 15 • 10 years ago

Comment on attachment 8428764 [details] [diff] [review]
fix.injecttouchevent.patch

Review of attachment 8428764 [details] [diff] [review]:
-----------------------------------------------------------------

My only concern is that some marionette tests might be using this function on HiDPI devices, and might break because of this change. We should keep an eye out for any Marionette failures after this lands.

::: dom/ipc/TabParent.cpp
@@ +2003,5 @@
> +  nsIDocument* doc = content->OwnerDoc();
> +  if (!doc || !doc->GetShell()) {
> +    return NS_ERROR_FAILURE;
> +  }
> +  nsPresContext* presContext = doc->GetShell()->GetPresContext();

Eventually we should refactor this boilerplate into a helper method. But no need to do that in this patch if you don't want to.

@@ +2009,3 @@
>    event.touches.SetCapacity(aCount);
>    for (uint32_t i = 0; i < aCount; ++i) {
> +    LayoutDeviceIntPoint pt = 

nit: trailing whitespace

	Chris Lord [:cwiiis]
	Comment 17 • 10 years ago

I'll push this (with nit fixed) as soon as the tree reopens.

	Chris Lord [:cwiiis]
	Comment 18 • 10 years ago

Pushed to inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/d0cd763cc5e8

	Ryan VanderMeulen [:RyanVM]
	Comment 21 • 10 years ago

https://hg.mozilla.org/mozilla-central/rev/d0cd763cc5e8