Closed
Bug 985015
Opened 11 years ago
Closed 11 years ago
browser_debugger.js fails on "gcliActor set"
Categories
(Firefox Graveyard :: Webapp Runtime, defect, P1)
Firefox Graveyard
Webapp Runtime
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 31
People
(Reporter: myk, Assigned: marco)
References
Details
(Keywords: regression)
Attachments
(1 file)
(deleted),
patch
|
past
:
review+
|
Details | Diff | Splinter Review |
The browser_debugger.js test script is failing on "gcliActor set":
0:25.70 TEST-UNEXPECTED-FAIL | chrome://mochitests/content/webapprtChrome/webapprt/test/chrome/browser_debugger.js | gcliActor set
0:25.70 Stack trace:
0:25.70 JS frame :: chrome://mochitests/content/webapprtChrome/webapprt/test/chrome/browser_debugger.js :: test/</</< :: line 24
0:25.70 JS frame :: resource://gre/modules/devtools/dbg-client.jsm :: DebuggerClient.requester/</< :: line 328
0:25.70 JS frame :: resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js :: makeInfallible/< :: line 80
0:25.70 JS frame :: resource://gre/modules/devtools/dbg-client.jsm :: DebuggerClient.prototype.onPacket/< :: line 727
0:25.70 JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: resolve :: line 118
0:25.70 JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: then :: line 43
0:25.70 JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: then :: line 153
0:25.70 JS frame :: resource://gre/modules/devtools/dbg-client.jsm :: DebuggerClient.prototype.onPacket :: line 731
0:25.70 JS frame :: resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/main.js -> resource://gre/modules/devtools/server/transport.js :: LDT_send/< :: line 258
0:25.70 JS frame :: resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js :: makeInfallible/< :: line 80
0:25.70 native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0
0:25.70
0:25.70 TEST-PASS | chrome://mochitests/content/webapprtChrome/webapprt/test/chrome/browser_debugger.js | profilerActor set
0:25.70 TEST-UNEXPECTED-FAIL | chrome://mochitests/content/webapprtChrome/webapprt/test/chrome/browser_debugger.js | gcliActor set
0:25.70 Stack trace:
0:25.70 JS frame :: chrome://mochitests/content/webapprtChrome/webapprt/test/chrome/browser_debugger.js :: test/</</< :: line 26
0:25.70 JS frame :: resource://gre/modules/devtools/dbg-client.jsm :: DebuggerClient.requester/</< :: line 328
0:25.70 JS frame :: resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js :: makeInfallible/< :: line 80
0:25.70 JS frame :: resource://gre/modules/devtools/dbg-client.jsm :: DebuggerClient.prototype.onPacket/< :: line 727
0:25.70 JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: resolve :: line 118
0:25.70 JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: then :: line 43
0:25.70 JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: then :: line 153
0:25.70 JS frame :: resource://gre/modules/devtools/dbg-client.jsm :: DebuggerClient.prototype.onPacket :: line 731
0:25.70 JS frame :: resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/main.js -> resource://gre/modules/devtools/server/transport.js :: LDT_send/< :: line 258
0:25.70 JS frame :: resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js :: makeInfallible/< :: line 80
0:25.70 native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0
Assignee | ||
Comment 1•11 years ago
|
||
Ah, I noticed this too. It's a recent regression, I'll try and bisect.
Assignee | ||
Updated•11 years ago
|
Assignee | ||
Comment 2•11 years ago
|
||
I think before bug 933727 GCLI was both a tab actor and a global actor, it is now just a tab actor.
Assignee | ||
Comment 3•11 years ago
|
||
I think several new actors have been added since we introduced the test, we may update the list of actors that we expect to be defined in another bug.
Assignee: nobody → mar.castelluccio
Status: NEW → ASSIGNED
Attachment #8396795 -
Flags: review?(past)
Comment 4•11 years ago
|
||
Comment on attachment 8396795 [details] [diff] [review]
Patch
Review of attachment 8396795 [details] [diff] [review]:
-----------------------------------------------------------------
Yes, gcli is now just a tab actor.
Attachment #8396795 -
Flags: review?(past) → review+
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Keywords: checkin-needed
Whiteboard: [fixed-in-fx-team]
Comment 6•11 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 31
Updated•9 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•