Closed Bug 985015 Opened 11 years ago Closed 11 years ago

browser_debugger.js fails on "gcliActor set"

Categories

(Firefox Graveyard :: Webapp Runtime, defect, P1)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 31

People

(Reporter: myk, Assigned: marco)

References

Details

(Keywords: regression)

Attachments

(1 file)

The browser_debugger.js test script is failing on "gcliActor set": 0:25.70 TEST-UNEXPECTED-FAIL | chrome://mochitests/content/webapprtChrome/webapprt/test/chrome/browser_debugger.js | gcliActor set 0:25.70 Stack trace: 0:25.70 JS frame :: chrome://mochitests/content/webapprtChrome/webapprt/test/chrome/browser_debugger.js :: test/</</< :: line 24 0:25.70 JS frame :: resource://gre/modules/devtools/dbg-client.jsm :: DebuggerClient.requester/</< :: line 328 0:25.70 JS frame :: resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js :: makeInfallible/< :: line 80 0:25.70 JS frame :: resource://gre/modules/devtools/dbg-client.jsm :: DebuggerClient.prototype.onPacket/< :: line 727 0:25.70 JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: resolve :: line 118 0:25.70 JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: then :: line 43 0:25.70 JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: then :: line 153 0:25.70 JS frame :: resource://gre/modules/devtools/dbg-client.jsm :: DebuggerClient.prototype.onPacket :: line 731 0:25.70 JS frame :: resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/main.js -> resource://gre/modules/devtools/server/transport.js :: LDT_send/< :: line 258 0:25.70 JS frame :: resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js :: makeInfallible/< :: line 80 0:25.70 native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0 0:25.70 0:25.70 TEST-PASS | chrome://mochitests/content/webapprtChrome/webapprt/test/chrome/browser_debugger.js | profilerActor set 0:25.70 TEST-UNEXPECTED-FAIL | chrome://mochitests/content/webapprtChrome/webapprt/test/chrome/browser_debugger.js | gcliActor set 0:25.70 Stack trace: 0:25.70 JS frame :: chrome://mochitests/content/webapprtChrome/webapprt/test/chrome/browser_debugger.js :: test/</</< :: line 26 0:25.70 JS frame :: resource://gre/modules/devtools/dbg-client.jsm :: DebuggerClient.requester/</< :: line 328 0:25.70 JS frame :: resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js :: makeInfallible/< :: line 80 0:25.70 JS frame :: resource://gre/modules/devtools/dbg-client.jsm :: DebuggerClient.prototype.onPacket/< :: line 727 0:25.70 JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: resolve :: line 118 0:25.70 JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: then :: line 43 0:25.70 JS frame :: resource://gre/modules/commonjs/sdk/core/promise.js :: then :: line 153 0:25.70 JS frame :: resource://gre/modules/devtools/dbg-client.jsm :: DebuggerClient.prototype.onPacket :: line 731 0:25.70 JS frame :: resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/server/main.js -> resource://gre/modules/devtools/server/transport.js :: LDT_send/< :: line 258 0:25.70 JS frame :: resource://gre/modules/commonjs/toolkit/loader.js -> resource://gre/modules/devtools/DevToolsUtils.js :: makeInfallible/< :: line 80 0:25.70 native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0
Ah, I noticed this too. It's a recent regression, I'll try and bisect.
Keywords: regression
OS: Mac OS X → All
Hardware: x86 → All
Depends on: 933727
Blocks: 933727
No longer depends on: 933727
I think before bug 933727 GCLI was both a tab actor and a global actor, it is now just a tab actor.
Attached patch Patch (deleted) — Splinter Review
I think several new actors have been added since we introduced the test, we may update the list of actors that we expect to be defined in another bug.
Assignee: nobody → mar.castelluccio
Status: NEW → ASSIGNED
Attachment #8396795 - Flags: review?(past)
Comment on attachment 8396795 [details] [diff] [review] Patch Review of attachment 8396795 [details] [diff] [review]: ----------------------------------------------------------------- Yes, gcli is now just a tab actor.
Attachment #8396795 - Flags: review?(past) → review+
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 31
Flags: in-testsuite+
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: