Closed
Bug 985217
Opened 11 years ago
Closed 11 years ago
[Skia] Update Skia, 2014-03-18 (Firefox 31)
Categories
(Core :: Graphics, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla31
People
(Reporter: gw280, Assigned: gw280)
References
(Blocks 1 open bug)
Details
Attachments
(5 files)
(deleted),
patch
|
snorp
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
snorp
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
snorp
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
snorp
:
review+
|
Details | Diff | Splinter Review |
(deleted),
patch
|
snorp
:
review+
|
Details | Diff | Splinter Review |
This is the first planned landing of the new Skia update schedule - once per train. This is targeting Firefox 31.
Assignee | ||
Comment 2•11 years ago
|
||
Enable legacy APIs for now, file bugs immediately after landing to track making the appropriate changes to gfx/2d to no longer require these.
Attachment #8394309 -
Flags: review?(snorp)
Assignee | ||
Comment 5•11 years ago
|
||
I missed upstreaming this the last time round. Will upstream asap.
Attachment #8394312 -
Flags: review?(snorp)
Updated•11 years ago
|
Attachment #8394309 -
Flags: review?(snorp) → review+
Updated•11 years ago
|
Attachment #8394310 -
Flags: review?(snorp) → review+
Updated•11 years ago
|
Attachment #8394311 -
Flags: review?(snorp) → review+
Updated•11 years ago
|
Attachment #8394312 -
Flags: review?(snorp) → review+
Comment 7•11 years ago
|
||
Comment on attachment 8394313 [details] [diff] [review] 0006-Bug-985217-Ensure-that-our-GLContext-is-current-and-.patch Review of attachment 8394313 [details] [diff] [review]: ----------------------------------------------------------------- ::: gfx/gl/SkiaGLGlue.cpp @@ +39,5 @@ > +} > + > +void EnsureGLContext(const GrGLInterface* i) > +{ > + const SkiaGLGlue* contextSkia = reinterpret_cast<const SkiaGLGlue*>(i->fCallbackData); Maybe add a null guard here, since maybe Skia will someday start calling this at creation time too.
Attachment #8394313 -
Flags: review?(snorp) → review+
Assignee | ||
Comment 8•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/dfba3a2480bc https://hg.mozilla.org/integration/mozilla-inbound/rev/e1176480f8de https://hg.mozilla.org/integration/mozilla-inbound/rev/7223dac2c37c https://hg.mozilla.org/integration/mozilla-inbound/rev/3c74cf8975d5 https://hg.mozilla.org/integration/mozilla-inbound/rev/46e992a65343 https://hg.mozilla.org/integration/mozilla-inbound/rev/e6a116d382ae
Comment 9•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/dfba3a2480bc https://hg.mozilla.org/mozilla-central/rev/e1176480f8de https://hg.mozilla.org/mozilla-central/rev/7223dac2c37c https://hg.mozilla.org/mozilla-central/rev/3c74cf8975d5 https://hg.mozilla.org/mozilla-central/rev/46e992a65343 https://hg.mozilla.org/mozilla-central/rev/e6a116d382ae
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
Updated•9 years ago
|
Blocks: skia-updates
Updated•5 years ago
|
Type: defect → enhancement
You need to log in
before you can comment on or make changes to this bug.
Description
•