Closed
Bug 985273
Opened 11 years ago
Closed 10 years ago
[DSDS] SIM labels of missed calls & sms in Notification is different
Categories
(Firefox OS Graveyard :: Gaia::SMS, defect)
Tracking
(tracking-b2g:backlog)
People
(Reporter: ericcc, Assigned: azasypkin)
References
Details
(Whiteboard: [sms-most-wanted][p=1])
Attachments
(3 files)
GAIA_REV=2346ad9002062d70b6b27978c6b942f04192bf1b GECKO_REV=93246f13841850c267bbb15915bffa7c2fcdac46 GAIA_BRANCH=mozillaorg/master GECKO_BRANCH=mozillaorg/master BUILD_TAG=jenkins-B2G.master.fugu-33 BuildID=20140319053035 1. Make missed calls and send SMS to Fugu. 2. Space missing in label. 3. Check Notification.png, (SIM 1) shown for missed call. (SIM1) for SMS.
Reporter | ||
Updated•11 years ago
|
blocking-b2g: --- → 1.4?
Comment 1•11 years ago
|
||
Hey Carrie, can you please comment whether we should have (SIM 1) or (SIM1) in the notification? I think the spec says that we have "SIM1" on buttons but "SIM 1" in notifications, that's why I'd like that you comment here :) Thanks!
Flags: needinfo?(cawang)
Updated•11 years ago
|
blocking-b2g: 1.4? → backlog
Updated•11 years ago
|
Whiteboard: [systemsfe]
Comment 2•11 years ago
|
||
Gregor, Joe, it's really a Comms App issue (either Dialer or SMS). Do you think we should retriage this on our side?
Flags: needinfo?(jcheng)
Flags: needinfo?(anygregor)
Comment 3•11 years ago
|
||
(In reply to Julien Wajsberg [:julienw] (away until March 24) from comment #2) > Gregor, Joe, it's really a Comms App issue (either Dialer or SMS). Do you > think we should retriage this on our side? Fine with me. I took it because fixing this typo is probably faster than discussing who should fix it :)
Component: Gaia::System → Gaia::SMS
Flags: needinfo?(anygregor)
Whiteboard: [systemsfe]
Comment 5•11 years ago
|
||
Hey Julien, it should always show "SIM 1" (with a space inserted). Thanks!
Flags: needinfo?(cawang)
Updated•11 years ago
|
blocking-b2g: backlog → 1.4?
Comment 6•11 years ago
|
||
with the correct comms team component, this will show up in comms team triage. will mark the bug appropriately in triage meeting
Flags: needinfo?(jcheng)
Updated•10 years ago
|
Whiteboard: [sms-most-wanted]
Reporter | ||
Updated•10 years ago
|
Summary: [DSDS] Fugu - SIM labels of missed calls & sms in Notification is different → [DSDS] SIM labels of missed calls & sms in Notification is different
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → azasypkin
Status: NEW → ASSIGNED
Assignee | ||
Comment 8•10 years ago
|
||
Hi Julien, I've just changed label in this patch. Probably we'll also need to deal later with the case when this label isn't translated right after language switch (in notification and report panel).
Attachment #8451454 -
Flags: review?(felash)
Comment 9•10 years ago
|
||
Comment on attachment 8451454 [details]
GitHub pull request URL
r=me if you keep it like this but please request another review if you decide to change dialog.js
Attachment #8451454 -
Flags: review?(felash) → review+
Assignee | ||
Comment 10•10 years ago
|
||
Comment on attachment 8451454 [details] GitHub pull request URL (In reply to Julien Wajsberg [:julienw] from comment #9) > Comment on attachment 8451454 [details] > GitHub pull request URL > > r=me if you keep it like this but please request another review if you > decide to change dialog.js Thanks for review! I've updated dialog.js (in a separate commit), so asking for review once again :)
Attachment #8451454 -
Flags: review+ → review?(felash)
Updated•10 years ago
|
Blocks: sms-sprint-2.0S6
Whiteboard: [sms-most-wanted] → [sms-most-wanted][p=1]
Updated•10 years ago
|
Target Milestone: --- → 2.0 S6 (18july)
Comment 11•10 years ago
|
||
Comment on attachment 8451454 [details]
GitHub pull request URL
r=me
please squash+rebase+wait for travis or gaia try, the usual drill :)
Attachment #8451454 -
Flags: review?(felash) → review+
Assignee | ||
Comment 12•10 years ago
|
||
(In reply to Julien Wajsberg [:julienw] from comment #11) > Comment on attachment 8451454 [details] > GitHub pull request URL > > r=me > please squash+rebase+wait for travis or gaia try, the usual drill :) Thanks! Master: https://github.com/mozilla-b2g/gaia/commit/dde24450450514039bad6d8ab4fcb7e5d4d44e03
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Reporter | ||
Comment 13•10 years ago
|
||
Verified fixed in v2.1, with flame Gaia d29773d2a011825fd77d1c0915a96eb0911417b6 Gecko https://hg.mozilla.org/mozilla-central/rev/4024d8019701 BuildID 20140716160202 Version 33.0a1 ro.build.version.incremental=109 ro.build.date=Mon Jun 16 16:51:29 CST 2014 B1TC00011220
Reporter | ||
Updated•10 years ago
|
Status: RESOLVED → VERIFIED
Updated•10 years ago
|
blocking-b2g: backlog → ---
tracking-b2g:
--- → backlog
You need to log in
before you can comment on or make changes to this bug.
Description
•