Closed
Bug 985291
Opened 11 years ago
Closed 9 years ago
Always use hash instead of build ID for cachebusting favicons, CSS, and JS
Categories
(Marketplace Graveyard :: Consumer Pages, defect, P2)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: cvan, Unassigned)
References
()
Details
(Keywords: perf, Whiteboard: [ktlo][possible_future_need])
1. When we deploy to production, our fabfile runs `commonplace includes`.
2. This writes to a file called `build_id.txt` a numeric timestamp.
3. Zamboni uses this timestamp to cachebust our favicons, stylesheets, and scripts (which are served from our CDN and have a `Cache-Control` `max-age` of 10 years). See view-source:https://marketplace.firefox.com/
4. If a resource hasn't changed, we still refetch the resource because the URL is different.
There are times (seldomly, albeit) when our stylesheets or scripts haven't changed. The favicons and splash screen change almost never. The main stylesheet and main JS bundle - those are almost guaranteed to have changed every push.
Anyway, we shouldn't be blindly cachebusting things if the content hasn't changed, like this one for example:
https://marketplace.cdn.mozilla.net/media/fireplace/img/logos/128.png?b=1395166222469
Reporter | ||
Updated•11 years ago
|
Reporter | ||
Updated•11 years ago
|
Reporter | ||
Updated•11 years ago
|
Updated•11 years ago
|
Blocks: tarako-marketplace
Updated•11 years ago
|
No longer blocks: tarako-marketplace
Reporter | ||
Updated•10 years ago
|
Updated•10 years ago
|
Blocks: marketplace-perf
Reporter | ||
Updated•10 years ago
|
Updated•10 years ago
|
Whiteboard: [ktlo]
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
Updated•9 years ago
|
Whiteboard: [ktlo] → [ktlo][possible_future_need]
You need to log in
before you can comment on or make changes to this bug.
Description
•