Closed Bug 985476 Opened 11 years ago Closed 11 years ago

[FxA][l10n][1.4] back out Firefox Account specific strings from 1.4

Categories

(Firefox OS Graveyard :: FxA, defect)

Product:
Firefox OS Graveyard
Component:
FxA
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:1.4+, b2g-v1.4 fixed, b2g-v2.0 unaffected)

Status:
RESOLVED FIXED
Milestone:
1.4 S4 (28mar)
Project Flags:
blocking-b2g 1.4+
Tracking Flags:
Tracking Status
b2g-v1.4 --- fixed
b2g-v2.0 --- unaffected

People

(Reporter: Pike, Assigned: jhirsch)

References

Details

Attachments

(1 file)

gaia pull request 17329
(deleted), text/x-github-pull-request
arcturus
: review+
Details
Sadly, we don't support any optional or preffed-on/off strings in the l10n files. As we're disabling FxA on 1.4 (per IRC), can we back out the strings? This would be 1.4 only.
Assignee: nobody → 6a68
Blocks: 941723
Attachment #8393524 - Flags: review?(francisco.jordano)
Comment on attachment 8393524 [details] gaia pull request 17329 I think this is gonna break the UI, at least for the js-hooked-up pieces. How are we going to switch this off for 1.4? Do we know that yet?
Lets get the additional strings backed out
blocking-b2g: 1.4? → 1.4+
Comment on attachment 8393524 [details] gaia pull request 17329 Easy one ;)
Attachment #8393524 - Flags: review?(francisco.jordano) → review+
RyanVM - note this one is headed to 1.4 only, not master
Flags: needinfo?(ryanvm)
Keywords: checkin-needed
(In reply to Axel Hecht [:Pike] from comment #2) > Comment on attachment 8393524 [details] > gaia pull request 17329 > > I think this is gonna break the UI, at least for the js-hooked-up pieces. > > How are we going to switch this off for 1.4? Do we know that yet? We discussed this on IRC a bit this morning, but just to overcommunicate in the bug, there's a pref (identity.fxaccounts.ui.enabled) which is set to false by default. The FTU code doesn't display the firefox accounts screen if this pref is false, so I think merging this patch should have no adverse effects. Does that answer your questions, Pike?
Flags: needinfo?(l10n)
Yes, thanks.
Flags: needinfo?(l10n)
v1.4: c0318e9dcafc13dc17869b1f83e1032ab5d2b07c
Status: NEW → RESOLVED
Closed: 11 years ago
status-b2g-v1.4: affected → fixed
status-b2g-v2.0: --- → unaffected
Flags: needinfo?(ryanvm)
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → 1.4 S4 (28mar)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: