Closed Bug 985509 Opened 11 years ago Closed 11 years ago

Edit Bookmark panel button doesn't have an open state

Categories

(Firefox :: Theme, defect)

Product:
Firefox
Component:
Theme
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 31
Tracking Flags:
Tracking Status
firefox29 --- wontfix
firefox30 --- verified
firefox31 --- verified

People

(Reporter: shorlander, Assigned: jaws)

References

Details

(Whiteboard: [Australis:P4+])

Attachments

(2 files, 2 obsolete files)

Edit Bookmark panel open screenshot
(deleted), image/png
Details
Patch v2
(deleted), patch
mconley
: review+
lsblakk
: approval-mozilla-aurora+
Sylvestre
: approval-mozilla-beta+
Details | Diff | Splinter Review
Attached image Edit Bookmark panel open screenshot (deleted) —
When you have the Edit Bookmark panel open there is no open state on the button.
Blocks: australis-navbar
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Attached patch Patch (obsolete) (deleted) — — Splinter Review
Mike, what do you think about this?
Attachment #8395083 - Flags: review?(mconley)
Comment on attachment 8395083 [details] [diff] [review] Patch I think the idea is fine, but I think we're probably going to want the same thing for OS X and Linux. :D
Attachment #8395083 - Flags: review?(mconley) → review-
Attached patch WIP Patch (obsolete) (deleted) — — Splinter Review
Attachment #8395083 - Attachment is obsolete: true
Attached patch Patch v2 (deleted) — — Splinter Review
Tested on OSX, Linux, and Windows.
Attachment #8407697 - Attachment is obsolete: true
Attachment #8407724 - Flags: review?(mconley)
Comment on attachment 8407724 [details] [diff] [review] Patch v2 Review of attachment 8407724 [details] [diff] [review]: ----------------------------------------------------------------- Awesome - thanks Jared!
Attachment #8407724 - Flags: review?(mconley) → review+
https://hg.mozilla.org/integration/fx-team/rev/b3ea0d746ee4
status-firefox29: --- → affected
status-firefox30: --- → affected
status-firefox31: --- → affected
OS: Mac OS X → All
Whiteboard: [Australis:P4+] → [Australis:P4+][fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/b3ea0d746ee4
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [Australis:P4+][fixed-in-fx-team] → [Australis:P4+]
Target Milestone: --- → Firefox 31
status-firefox31: affected → fixed
Flags: in-testsuite+
Comment on attachment 8407724 [details] [diff] [review] Patch v2 [Approval Request Comment] Bug caused by (feature/regressing bug #): bug introduced with Australis when the bookmarks button was separated out of the location bar User impact if declined: when the Edit Bookmarks panel is open, the originating button wont look pressed-in. Testing completed (on m-c, etc.): locally, and now on m-c Risk to taking this patch (and alternatives if risky): none expected String or IDL/UUID changes made by this patch: none
Attachment #8407724 - Flags: approval-mozilla-aurora?
Depends on: 998687
Attachment #8407724 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
I will hold off on uplifting this until we have a proper fix for bug 998687.
Comment on attachment 8407724 [details] [diff] [review] Patch v2 NOTE : The approval flag was asked for Aurora 30 but one cycle passed by, and now the patch is on Aurora. So let's ask for Beta 30 approval now. ***** [Approval Request Comment] Bug caused by (feature/regressing bug #): bug introduced with Australis when the bookmarks button was separated out of the location bar User impact if declined: when the Edit Bookmarks panel is open, the originating button wont look pressed-in. Testing completed (on m-c, etc.): locally, and now on m-c Risk to taking this patch (and alternatives if risky): none expected String or IDL/UUID changes made by this patch: none
Attachment #8407724 - Flags: approval-mozilla-beta?
Attachment #8407724 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
This needs to be checked in along with bug 998687
Keywords: checkin-needed
I was able to confirm the fix for this issue on Firefox 30 Beta 6 build2 (Build ID: 20140520115057) and Aurora 31.0a2 (2014-05-20), using: * Windows 7 64-bit [1], * Windows 8.1 32-bit [2], * Mac OS X 10.9.2 [3], * Ubuntu 12.04 32-bit [4]. [1] Mozilla/5.0 (Windows NT 6.1; WOW64; rv:30.0) Gecko/20100101 Firefox/30.0 [2] Mozilla/5.0 (Windows NT 6.3; rv:30.0) Gecko/20100101 Firefox/30.0 [3] Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:30.0) Gecko/20100101 Firefox/30.0 [4] Mozilla/5.0 (X11; Linux i686; rv:30.0) Gecko/20100101 Firefox/30.0
Status: RESOLVED → VERIFIED
status-firefox30: fixed → verified
status-firefox31: fixed → verified
Keywords: verifyme
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: