We have already runEmulatorCmd, which executes a string command in emulator console through telnet. However, that means you need to commit some changes to "external/qemu/android/console.c" in order to add new commands. It will be very handy if we allow executing arbitrary commands through "adb shell" and then we can examine the response without touching one line in qemu source.

Hi Malini Das, may I have your review?

Comment on attachment 8393594 [details] [diff] [review] patch Review of attachment 8393594 [details] [diff] [review]: ----------------------------------------------------------------- This looks really good, thanks!

Hi, after some more thoughts, this shouldn't be named as runEmulatorShell because it's common to all adb-enabled devices. runEmulatorCmd is emulator specific because only emulator has that telnet service. I think I should have named it as runAdbShell. How do you think?

(In reply to Vicamo Yang [:vicamo][:vyang] from comment #4) > Hi, after some more thoughts, this shouldn't be named as runEmulatorShell > because it's common to all adb-enabled devices. runEmulatorCmd is emulator > specific because only emulator has that telnet service. I think I should > have named it as runAdbShell. How do you think? Sorry, after some more deep diving into Marionette source code, that doesn't work because we don't have anything abstracting ADB in class Marionette when its |self.emulator| is not defined. So let's take that reviewed patch.

Nominate for 1.4: The test case of bug 990383 needs this marionette command.

Has automatic approval. No need to request approval here