Hi, I've reviewed the patch and here is my feedback on the confirmation messages (also attached specs): HDR message is wrong: When user selects HDR ON, the confirmation message says “HDR: off” When user selects HDR OFF, the confirmation message says “hdr-set-off” Correct Behaviour: When user selects HDR ON, the confirmation message should say “HDR ON” When user selects HDR OFF, the confirmation message should say “HDR OFF” Text Style: The text style is wrong (i.e setting item should be sentence case, and selected state should be all uppercase, should be broken into two lines). I have attached a spec for how the text should be formatted. Please follow the specs for correct text style. Confirmation Message distance to edge of screen is wrong in all orientations: Please see attached spec for correct spacing measurements. Font style/size: Font should be Fira Sans Medium, 2.0 rem (looks like Fira Sans Regular) Landscape Orientation: Confirmation message should be horizontally centered to screen (looks off)

Youngjun to assign (blocker bugs are first priority)

Bug-948263 will fix this issue by Ashish.

Flagging Tif so she is aware of this. We also need to be mindful that the confirmation messages actually make it into 1.4, and that string freeze is tomorrow, March 28, so let's make sure these correct strings make it in. Thanks, all!

Yes! A big item we learned this week during usability testing was users were super confused by what was happening in the UI without the confirmation messages. These messages not only confirm to the user what is happening, but can also provide critical information as to what the icon means, like with flash (yep, a couple people did not get the flash icon). Let me confirm uppercase vs sentence case with Amy and Rob tomorrow AM as I believe our style guidelines may have been updated.

Also, if you could attach patches to the bug, that would be super helpful. I haven't seen confirmation messages working yet.

Discussed with Rob and Amy this AM. We are no longer using uppercase for styling. Text should still be broken to two lines. e.g Flash On Sorry for any confusion and thanks!

Stealing this per IRC discussion.

Hmm, is this already fixed? I'm testing this out on master and it seems to do what it should, except for the capitalization mentioned in comment 7.

squib: I noticed that this morning too. It looks like it may have been fixed by this bug: Bug 988108 - [camera][madai] capitalization corrections tif: Can you look at the messages on master and mark this as RESOLVED DUPLICATE if that is the case?

All the strings in Master are the correct casing and there is another bug to add confirmation messaging for the HDR/Flash conflicts. This looks to be a dup to me.

FYI - here's the bug for the HDR/Flash conflicts - Bug 991384