Closed
Bug 98598
Opened 23 years ago
Closed 23 years ago
Active Accessibility: support XUL radio buttons
Categories
(Core :: XUL, defect, P1)
Tracking
()
RESOLVED
FIXED
mozilla0.9.7
People
(Reporter: mozilla, Assigned: mozilla)
References
()
Details
(Keywords: access)
Attachments
(1 file, 2 obsolete files)
(deleted),
patch
|
aaronlev
:
review+
|
Details | Diff | Splinter Review |
Need to hook up through XBL an implementation of nsIAccessibleProvider support
for MSAA.
Assignee | ||
Updated•23 years ago
|
Assignee | ||
Comment 1•23 years ago
|
||
Assignee | ||
Updated•23 years ago
|
Target Milestone: mozilla0.9.5 → mozilla0.9.6
Assignee | ||
Comment 2•23 years ago
|
||
Assignee | ||
Comment 3•23 years ago
|
||
Comment on attachment 50956 [details] [diff] [review]
first whack - idl and makefiles
Aaron, pls take a look at the new patch for review.
Attachment #50956 -
Attachment is obsolete: true
Comment 4•23 years ago
|
||
I applied this patch, but I had to do most of it by hand. Has it been manually
edited? The patch utility got to the last dom\public\idl\xul\makefile.win, then
reported "illegal patch". The radio.xml part of the patch is also wrong - the
2nd section of it doesn't have the @context line.
Testing it, I found that radio buttons themselves didn't work, but the radio
group did (although it is reported as a radio button itself). I'm not sure what
role the radio group should have, but in windows, it's generally reported as a
"WINDOW". I'll contact one of the screen reader vendors and find out what they
think it should be.
Also, this should probably be removed:
+// printf("CreateXULRadioGroupAccessible()\n");
Finally, we need a newline at end of nsXULFormControlAccessible.cpp
Assignee | ||
Comment 5•23 years ago
|
||
You'll notice the dependancy on 96019.
This patch is from a tree already patched with the code for 96019, and a little
more not in that patch ( stuff directly from blake that he hasn't posted to the
bug yet ). To be honest, I'm surprised any of it works without the stuff from
96019.
I'll take care of the printf and newline.
Assignee | ||
Comment 6•23 years ago
|
||
For the radio groups we need to report the role as: ROLE_GROUPING per GW Micro's
request.
Assignee | ||
Comment 7•23 years ago
|
||
The impl for this fix needs some of the reworking that was done for the select
impl -- see bug 108069 for more.
Depends on: 108069
Comment 8•23 years ago
|
||
*** Bug 109228 has been marked as a duplicate of this bug. ***
Updated•23 years ago
|
Keywords: fcc508
Summary: Implement accessibility support for XUL radio buttons → Active Accessibility: support XUL radio buttons
Assignee | ||
Updated•23 years ago
|
Target Milestone: mozilla0.9.6 → mozilla0.9.7
Assignee | ||
Comment 9•23 years ago
|
||
ironed out circular reference et al problems.
aaronl: ready for review
Attachment #52958 -
Attachment is obsolete: true
Comment 10•23 years ago
|
||
Comment on attachment 59256 [details] [diff] [review]
v3.0 of radio button Acc
r=aaronl
Attachment #59256 -
Flags: review+
Assignee | ||
Updated•23 years ago
|
Whiteboard: ready for sr
Assignee | ||
Updated•23 years ago
|
Whiteboard: ready for sr → waiting on sr
Comment 11•23 years ago
|
||
Change "RadiobuttonStateChange" to be "RadioStateChange". Change
"MutationEvents" to just be "Events", since this custom event isn't really a
mutation event.
With those changes, sr=hyatt
Comment 12•23 years ago
|
||
Hey wait a minute, why can't you just listen for onselect? Why do you need your
own event here?
Assignee | ||
Comment 13•23 years ago
|
||
checked in
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Whiteboard: waiting on sr
Comment 14•6 years ago
|
||
Keywords: sec508
You need to log in
before you can comment on or make changes to this bug.
Description
•