Closed
Bug 986195
Opened 11 years ago
Closed 11 years ago
test_jsctypes.js xpcshell test fails in Windows 64-bit builds | "expected Error exception, none thrown"
Categories
(Core :: js-ctypes, defect)
Tracking
()
RESOLVED
FIXED
mozilla31
People
(Reporter: TimAbraldes, Assigned: TimAbraldes)
References
Details
Attachments
(1 file, 1 obsolete file)
|
(deleted),
patch
|
TimAbraldes
:
review+
|
Details | Diff | Splinter Review |
Example failure:
https://tbpl.mozilla.org/php/getParsedLog.php?id=36287210&tree=Date
|
Assignee | |
Comment 1•11 years ago
|
||
Making the code match the comment. Super happy that the comment exists, by the way :)
|
||
Comment 2•11 years ago
|
||
One more down... awesome and thanks!
|
|
Assignee | |
Comment 3•11 years ago
|
||
Comment on attachment 8394437 [details] [diff] [review]
Patch v1
Tested locally with win64 and win32 builds. Both passed the test_jsctypes.js test (when previously the win64 build would fail)
Attachment #8394437 -
Flags: review?(nfroyd)
|
|
Assignee | |
Updated•11 years ago
|
Status: NEW → ASSIGNED
|
|
||
Comment 4•11 years ago
|
||
Comment on attachment 8394437 [details] [diff] [review]
Patch v1
Review of attachment 8394437 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks for finding and fixing my mistake!
Attachment #8394437 -
Flags: review?(nfroyd) → review+
|
|
Assignee | |
Comment 5•11 years ago
|
||
Updating patch to contain "r=froydnj"
Attachment #8394437 -
Attachment is obsolete: true
Attachment #8397408 -
Flags: review+
|
|
Assignee | |
Comment 6•11 years ago
|
||
Setting checkin-needed (no need to land this separately and waste build resources)
Keywords: checkin-needed
|
||
Comment 7•11 years ago
|
||
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla31
You need to log in
before you can comment on or make changes to this bug.
Description
•