Closed
Bug 986400
Opened 11 years ago
Closed 11 years ago
Sync does not start in SeaMonkey 2.28a1
Categories
(SeaMonkey :: Sync UI, defect)
SeaMonkey
Sync UI
Tracking
(seamonkey2.28 fixed)
RESOLVED
FIXED
seamonkey2.28
Tracking | Status | |
---|---|---|
seamonkey2.28 | --- | fixed |
People
(Reporter: hhofer42, Assigned: philip.chee)
References
Details
Attachments
(1 file)
(deleted),
patch
|
Callek
:
review+
|
Details | Diff | Splinter Review |
User Agent: Mozilla/5.0 (Windows NT 5.1; rv:31.0) Gecko/20100101 Firefox/31.0 SeaMonkey/2.28a1 (Beta/Release)
Build ID: 20140320003001
Steps to reproduce:
Starting SeaMonkey (or manually triggering a sync)
Actual results:
An error message in the log:
> Error: NS_ERROR_FILE_NOT_FOUND: Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsIXPCComponents_Utils.import]
> Source File: resource://gre/modules/services-sync/browserid_identity.js
> Line: 23
The offending line is:
> Cu.import("resource://gre/modules/FxAccounts.jsm");
Expected results:
The 'FxAccounts.jsm' and dependent modules should have been included in 'omni.ja'
Assignee | ||
Updated•11 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows XP → All
Hardware: x86 → All
Comment 1•11 years ago
|
||
I wonder how FF packages the missing file. The only place of reference I could find was /mozilla/services/fxaccounts/moz.build. Nothing in any package-manifest.in.
Assignee | ||
Comment 3•11 years ago
|
||
(In reply to Jens Hatlak (:InvisibleSmiley) from comment #1)
> I wonder how FF packages the missing file. The only place of reference I
> could find was /mozilla/services/fxaccounts/moz.build. Nothing in any
> package-manifest.in.
It's in suite/confvars.sh we need to port the change from mozilla/browser/confvars.sh
Assignee | ||
Comment 4•11 years ago
|
||
One line fix from https://hg.mozilla.org/mozilla-central/rev/806f7c40cccf#l8.12
Assignee: nobody → philip.chee
Status: NEW → ASSIGNED
Attachment #8395420 -
Flags: review?(jh)
Attachment #8395420 -
Flags: review?(bugspam.Callek)
Comment 5•11 years ago
|
||
Comment on attachment 8395420 [details] [diff] [review]
Patch v1.0 One line fix.
Review of attachment 8395420 [details] [diff] [review]:
-----------------------------------------------------------------
my only concern here is that we don't actually have UX/UI around "Firefox Accounts" and merely around "Sync" two different backends entirely. I Know we want "<> Accounts" working of course.
Attachment #8395420 -
Flags: review?(bugspam.Callek) → review+
Assignee | ||
Comment 6•11 years ago
|
||
(In reply to Justin Wood (:Callek) from comment #5)
> my only concern here is that we don't actually have UX/UI around "Firefox
> Accounts" and merely around "Sync" two different backends entirely. I Know
> we want "<> Accounts" working of course.
I intend to get our Sync UI updated, then I'll look into FxAccounts (or would it be SmAccounts?)
Assignee | ||
Comment 7•11 years ago
|
||
I pushed to comm-central:
comm-central changeset 28b75077c9ef
http://hg.mozilla.org/comm-central/rev/28b75077c9ef
Assignee | ||
Updated•11 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
status-seamonkey2.28:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.28
Updated•11 years ago
|
Attachment #8395420 -
Flags: review?(jh)
You need to log in
before you can comment on or make changes to this bug.
Description
•