Closed Bug 986460 Opened 11 years ago Closed 11 years ago

Settings app is totally broken: unable to navigate

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

ARM
Gonk (Firefox OS)
defect
Not set
blocker

Tracking

(blocking-b2g:2.0+, b2g-v2.0 fixed)

RESOLVED FIXED
2.0 S1 (9may)
blocking-b2g 2.0+
Tracking Status
b2g-v2.0 --- fixed

People

(Reporter: gerard-majax, Unassigned)

References

Details

(Keywords: regression, smoketest)

Up-to-date Gecko/Gaia, Settings app is not usable at all. STR: 0. Launch settings Expected: I can tap and go into submenus. Actual: I can tap but nothing happens. Disabled items are still visible while they should be either enabled (Call settings) or hidden (SIM card manager on my single SIM device). This is reproducing on Nexus S and Keon at least. Yesterday it was fine.
Reflashing the app by hand in production mode, with GAIA_OPTIMIZE=0 fixes the issue. Reflashing in production mode but with GAIA_OPTIMIZE=1 reproduces the issue. Of course, logcat shows no error.
I bisected this problem to: > commit d9fb81e2d83dae21e53496b697cdd10ad6a2d4fd > Author: Arthur Chen <crh0716@gmail.com> > Date: Mon Feb 10 16:53:05 2014 +0800 > > Bug 964180 - Introduce AMD to settings app > 1. Support new panel model > 2. Separate common logic to SettingsCache, PanelUtils, PageTransitions using the following command to install: > make MOZILLA_OFFICIAL=1 PRODUCTION=1 NOFTU=1 REMOTE_DEBUGGER=1 APP=settings install-gaia and checking if I could access submenus on the device.
per comment 1, looks like the makefile build error...
Flags: needinfo?(arthur.chen)
Please check if this can be reproduced
Keywords: qawanted
It repros Gaia 2c06eb8cfc7eee1021c868a6a8b030242007b684 Gecko https://hg.mozilla.org/mozilla-central/rev/c148f0b0c8b4 BuildID 20140321040203 Version 31.0a1 ro.build.version.incremental=eng.tclxa.20131223.163538 ro.build.date=Mon Dec 23 16:36:04 CST 2013 Buri Settings is busted.
Works on : Gaia db2ef2b61c70889533a0837fa3e053d24e95fdea Gecko https://hg.mozilla.org/mozilla-central/rev/e84a391b604b BuildID 20140320160206 Version 31.0a1 ro.build.version.incremental=eng.tclxa.20131223.163538 ro.build.date=Mon Dec 23 16:36:04 CST 2013 Buri
Looks like something in gecko checkin : c148f0b0c8b4
The reason I say this is because I made my own build with gecko with the revision prior to that gecko checkin with the latest gaia: Gaia db91804c290f7ed40ba5386a73ae3c23b393000c Gecko 61a24bdc03f965ea63a6bb908ebc95335c215ef7 BuildID 20140321123555 Version 31.0a1 ro.build.version.incremental=eng.tclxa.20131223.163538 ro.build.date=Mon Dec 23 16:36:04 CST 2013 Please take a look into : https://hg.mozilla.org/mozilla-central/rev/c148f0b0c8b4
We still need to know if this happens on 1.4.
Keywords: qawanted
This issue is not reproducing on today's Buri v1.4 v1.4 Environmental Variables: Device: Buri v1.4 MOZ BuildID: 20140321000202 Gaia: b09bf796d82ca7aa00d141a0cb705ee9cabfab47 Gecko: 81bfa88dada6 Version: 30.0a2 Firmware Version: v1.2-device.cfg
Keywords: qawanted
QA Contact: pbylenga
Blocks: 986535
blocking-b2g: 1.4? → 1.5?
According to Mike, bug 964180 is suspected for causing this.
Blocks: 964180
I'm still leaving the window request though on here to confirm that analysis in comment 12 is right.
Gaia-Gecko Swap test on Tinderbox m-c builds revealed it was a Gaia issue, moved to B2G-Inbound and confirmed the findings along with a narrower commit list. Last working B2G-Inbound v1.5 Environmental Variables: Device: Buri v1.5 MOZ BuildID: 20140319000201 Gaia: db2ef2b61c70889533a0837fa3e053d24e95fdea Gecko: a6476baa3307 Version: 31.0a1 Firmware Version: v1.2-device.cfg First Broken B2G-Inbound v1.5 Environmental Variables: Device: Buri v1.5 MOZ BuildID: 20140319053902 Gaia: e0add8a95f4d1ca26f3bf83d32c58cab7a16826b Gecko: 63a022bb94c6 Version: 31.0a1 Base Image: V1.2-device.cfg Last Working Gaia / First Broken Gecko: Issue Does NOT reproduce Gaia: db2ef2b61c70889533a0837fa3e053d24e95fdea Gecko: 63a022bb94c6 Last Working Gecko / First Broken Gaia: Issue DOES reproduce Gaia: e0add8a95f4d1ca26f3bf83d32c58cab7a16826b Gecko: a6476baa3307 B2G-Inbound Gaia Pushlog: https://github.com/mozilla-b2g/gaia/compare/db2ef2b61c70889533a0837fa3e053d24e95fdea...e0add8a95f4d1ca26f3bf83d32c58cab7a16826b Tinderbox Gaia Pushlog: https://github.com/mozilla-b2g/gaia/compare/db2ef2b61c70889533a0837fa3e053d24e95fdea...06d3242182370ba93db9acbe54cbe6cc8f7b239f Tinderbox Gecko Pushlog (for error checking): http://hg.mozilla.org//mozilla-central/pushloghtml?fromchange=2d20e6067412&tochange=cf485c48b52f
I'm testing locally, and will attempt a backout if I find the culprit.
I backed out the settings app refactor from bug 964180 [1], resolved the merge conflict in 'apps/settings/index.html', then flashed it onto my Keon with build id 20140321024129. I was then able to navigate the settings app. Based on comment 8, there is probably a gecko thing here too, but I think we should fix this by backing out d9fb81e2d83dae21e53496b697cdd10ad6a2d4fd. Unfortunately, there are too many merge conflicts (mostly in tests) for me to do this myself. 1.) https://github.com/mozilla-b2g/gaia/commit/d9fb81e2d83dae21e53496b697cdd10ad6a2d4fd
To be honest, it's probably way less risky to just diagnose and fix this problem, then it would be to back out this patch. </my2cents>
I backed out the patches of bug 964180[1] and bug 985409[2]. Travis is green[3]. [1] 6180c5c733a4399e75d0b3c70e8b45743f20032f [2] 61c408c49aa8f3da0f5bec4c9bc6a5f62aa4db39 [3] https://github.com/mozilla-b2g/gaia/pull/17477
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: needinfo?(arthur.chen)
Resolution: --- → FIXED
No longer blocks: 986535
blocking-b2g: 2.0? → 2.0+
Target Milestone: --- → 2.0 S1 (9may)
You need to log in before you can comment on or make changes to this bug.