We currently have methods on gfxASurface to encode the surface to PNG/JPEG/BMP/ICO and write out the encoded data to file, stdout or to the clipboard. We don't want to create a gfxASurface in order to do these things for a SourceSurface though. We should create separate helpers for SourceSurface then start to migrate code over to these new helpers.

I've made this fairly general because I have more WIP code to make other parts of the codebase use these helpers rather than create their own encoder. I keep getting bitrotted though, so I'd like to get this part out of my queue. This is prerequisite work to getting rid of various Thebes backed gfxContexts.

Comment on attachment 8446794 [details] [diff] [review] patch Review of attachment 8446794 [details] [diff] [review]: ----------------------------------------------------------------- ::: gfx/thebes/gfxUtils.h @@ +269,5 @@ > +#ifdef DEBUG > + static void WriteAsPNG(nsIPresShell* aShell, const char* aFile); > +#endif > + > +#if defined(DEBUG) || defined(MOZ_DUMP_PAINTING) Let's just make these always defined. There shouldn't be any runtime overhead for having them around, and they can be useful in opt builds. ::: layout/reftests/svg/as-image/lime100x100-noSVGDimensions.svg @@ +1,3 @@ > <svg xmlns="http://www.w3.org/2000/svg" version="1.1"> > <rect width="100" height="100" fill="lime"/> > + <circle cx="50" cy="50" r="50" fill="red"/> I assume this change wasn't meant to be here?

Comment on attachment 8446794 [details] [diff] [review] patch https://hg.mozilla.org/integration/mozilla-inbound/rev/54bccb704e1f