Closed Bug 986635 Opened 11 years ago Closed 10 years ago

[UX] Visual design for dark theme for private browsing mode

Categories

(Firefox :: Private Browsing, defect)

x86
All
defect
Not set
normal

Tracking

()

VERIFIED FIXED

People

(Reporter: zfang, Assigned: shorlander)

References

()

Details

(Whiteboard: [ux] p=0 s=it-32c-31a-30b.3 [qa-])

Attachments

(2 files, 1 obsolete file)

Currently we have two initial mockups for private browsing dark theme: http://people.mozilla.org/~shorlander/private-browsing-mode/mockups/australis-pbm.png We need to finalize the visual design for private browsing mode, including: - Different platforms - Tweak the current design so that it's more subtle, less dramatic - Add an icon indicator in addition to the dark theme, to make it more clear which mode the user is in, especially for people using dark theme * The placement/style of the indicator need to be consistent with the multi-user feature that might come out in the future
(In reply to Zhenshuo Fang (:fang) - Firefox UX Team from comment #0) > - Tweak the current design so that it's more subtle, less dramatic Why does it need to be more subtle?
Whiteboard: p=0
Based on a conversation with shorlander on irc, we decided to not have an icon indicator in the tab area but use the purple menu button as an indication for start. shorlander will take another look at the design above and add a Linux version.
The private browsing in-content message could also benefit from this dark theme.
(In reply to Guillaume C. [:ge3k0s] from comment #3) > The private browsing in-content message could also benefit from this dark > theme. Oups didn't see it was bug 986644.
Assignee: nobody → shorlander
Whiteboard: p=0 → p=8
No longer blocks: fxdesktopbacklog
Flags: firefox-backlog+
Attached image PrivateBrowsingMode-Specs-(OSX) (deleted) —
Updated Spec for OSX based on shipping Australis. Includes various states the main browser chrome can find itself in. Windows and Linux coming up next.
Still some questions : - will themes be disabled during PBM ? (FYI some themes are dark too) - should we update the Icui description mentioning Windows are dark during ONE ?
(In reply to Tim Nguyen [:ntim] from comment #6) > Still some questions : > - will themes be disabled during PBM ? (FYI some themes are dark too) > - should we update the Icui description mentioning Windows are dark during > ONE ? PBM*
Assignee: shorlander → mmaslaney
Status: NEW → ASSIGNED
Whiteboard: p=8 → [ux] p=8 s=it-32c-31a-30b.1 [qa-]
Whiteboard: [ux] p=8 s=it-32c-31a-30b.1 [qa-] → [ux] p=8 s=it-32c-31a-30b.2 [qa-]
Attached image Private Browsing Mode Specs — i01 (obsolete) (deleted) —
The color value changes should mostly be CSS and we can probably use the inverted set. It might need some new assets.
Attached image Private Browsing Mode Specs — i01 (deleted) —
Oops, added OS X titlebar, Windows glass fog and Linux tab bar background color values.
Attachment #8426436 - Attachment is obsolete: true
Whiteboard: [ux] p=8 s=it-32c-31a-30b.2 [qa-] → [ux] p=8 s=it-32c-31a-30b.3 [qa-]
Assignee: mmaslaney → shorlander
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
What about comment 6 ?
Flags: needinfo?(shorlander)
Status: RESOLVED → VERIFIED
Whiteboard: [ux] p=8 s=it-32c-31a-30b.3 [qa-] → [ux] p=0 s=it-32c-31a-30b.3 [qa-]
(In reply to Stephen Horlander [:shorlander] from comment #9) > Created attachment 8426441 [details] > Private Browsing Mode Specs — i01 > > Oops, added OS X titlebar, Windows glass fog and Linux tab bar background > color values. How is the menu button supposed to look when the bookmarks toolbar is visible?
Status: VERIFIED → RESOLVED
Closed: 10 years ago10 years ago
(In reply to Dão Gottwald [:dao] from comment #11) > (In reply to Stephen Horlander [:shorlander] from comment #9) > > Created attachment 8426441 [details] > > Private Browsing Mode Specs — i01 > > > > Oops, added OS X titlebar, Windows glass fog and Linux tab bar background > > color values. > > How is the menu button supposed to look when the bookmarks toolbar is > visible? Madhava and Philipp commented that this bug can be considered verified and that a separate engineering implementation bug will be filed by Philipp to address the question.
Status: RESOLVED → VERIFIED
Flags: needinfo?(shorlander)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: