Closed
Bug 986676
Opened 11 years ago
Closed 4 years ago
Store the search engine icons more efficiently
Categories
(Firefox :: Search, defect, P4)
Firefox
Search
Tracking
()
RESOLVED
INVALID
People
(Reporter: mccr8, Unassigned)
References
Details
(Whiteboard: [MemShrink:P3][fxteam])
No description provided.
Reporter | ||
Comment 1•11 years ago
|
||
I see four copies of this URI in memory at startup, plus another copy in some giant JSON as the data for a key of _dataURL.
Reporter | ||
Comment 2•11 years ago
|
||
Which is 42kb just for the Yahoo icon.
Comment 3•11 years ago
|
||
For context, we support installing arbitrary search engines, and their icons are specified in the OpenSearch description file (XML) as base64 encoded data: URIs generally. This includes our built-in engines. We could probably change the built-in engines to refer to chrome:// URIs instead, but it would complicate things a bit (requiring some search service tweaks, makes the search engine definitions not self-contained and so harder to maintain, etc.), so I'd want to avoid that unless it's a significant win.
Reporter | ||
Updated•11 years ago
|
Summary: Don't store the search engine icons as data URIs → Store the search engine icons more efficiently
Reporter | ||
Comment 4•11 years ago
|
||
Here's an example of the search engine icon:
http://mxr.mozilla.org/mozilla-central/source/browser/locales/en-US/searchplugins/yahoo.xml
All of them are defined on a single line, so they shouldn't hit the problem that the Google icon had.
Comment 5•11 years ago
|
||
They're also in XML files, and so not parsed by the JS engine :)
Updated•9 years ago
|
Whiteboard: [MemShrink:P3]
Updated•9 years ago
|
Priority: -- → P4
Whiteboard: [MemShrink:P3] → [MemShrink:P3][fxteam]
Comment 6•4 years ago
|
||
No long valid, these are stored in webExtensions now
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•