Closed
Bug 986829
Opened 10 years ago
Closed 9 years ago
Cosmetic: OSX Australis: needs a line to the left of the leftmost tab
Categories
(Firefox :: Theme, defect)
Tracking
()
RESOLVED
INVALID
People
(Reporter: zwol, Unassigned)
References
Details
(Whiteboard: [Australis:P5])
Attachments
(1 file)
(deleted),
image/png
|
Details |
On OSX, the Australis theme doesn't have any visual indication of where the leftmost tab ends when it's not hovered, which makes it look like the favicon is just floating out there in space and not associated with the tab. See attached screenshot. I think it would be enough to put another hairline there, like the one that appears between two unselected tabs (also visible in the screenshot). I haven't looked at Australis anywhere but OSX yet - this might apply to Windows and Linux too.
Comment 1•10 years ago
|
||
This is implemented according to the design spec[1] so you'd have to take this up with Stephen. If we did this, wouldn't we want consistency and put a line on the right side of the new tab button when tabs aren't overflowing? [1] https://people.mozilla.org/~shorlander/files/australis-designSpecs/australis-designSpecs-osx-mainWindow.html
Reporter | ||
Comment 2•10 years ago
|
||
(In reply to Matthew N. [:MattN] from comment #1) > This is implemented according to the design spec[1] so you'd have to take > this up with Stephen. It looks to me like the spec failed to consider the case where there are no pinned tabs. (I never pin tabs.) When there is a pinned tab there *is* a line to the left of the first normal tab, so the favicon for the first normal tab looks like it belongs with its tab. But when there are no pinned tabs, the leftmost favicon has nothing to group it with the tab; it appears to be floating in space halfway between the window buttons and the first normal tab's title, which is bad. When there are pinned tabs, a line to the left of the first pinned tab *would* make things visually clearer in some circumstances -- for instance, in the "live preview" in that mockup, there are two pinned tabs, neither of which has an icon; when a tab other than the leftmost pinned tab is selected, it is not obvious that there *is* another tab to the left of the second pinned tab. However, in practice I think there will always be an icon, so it is not as important to add a line then. But I think it would be better. > If we did this, wouldn't we want consistency and put a > line on the right side of the new tab button when tabs aren't overflowing? The new-tab button is not a tab. It *should* appear to belong to the area beyond the tabs.
Comment 3•9 years ago
|
||
The absence of a line is an indicator of the start and end of the tab strip. There are some variable that will affect what the first tab looks like. The length of the title and the width of the tab. In many cases the space will not be so drastic, and even in the screenshot I don't think it is problematic.
Status: UNCONFIRMED → RESOLVED
Closed: 9 years ago
Flags: needinfo?(shorlander)
Resolution: --- → INVALID
Updated•9 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•