Closed Bug 986852 Opened 11 years ago Closed 11 years ago

Email invitation only sent to the first attendee, if "Separate invitation per attendee" is checked

Categories

(Calendar :: E-mail based Scheduling (iTIP/iMIP), defect)

Lightning 3.3
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: MakeMyDay, Assigned: MakeMyDay)

Details

(Keywords: regression)

Attachments

(1 file)

If "Separate invitation per attendee" is checked in invitation dialog, only the attendee in the list is notified - see also comment 17 of bug 544169. Regression of bug 966292.
Attachment #8395269 - Flags: review?(philipp)
Comment on attachment 8395269 [details] [diff] [review] SendUndiclosedToAllAttendees-V1.diff Review of attachment 8395269 [details] [diff] [review]: ----------------------------------------------------------------- r=philipp with this comment considered: ::: calendar/base/modules/calItipUtils.jsm @@ +992,2 @@ > } > + return true; Shouldn't we unconditionally be sending the messages and returning true iff all of them have been sent?
Attachment #8395269 - Flags: review?(philipp) → review+
(In reply to Philipp Kewisch [:Fallen] from comment #2) > > Shouldn't we unconditionally be sending the messages and returning true iff > all of them have been sent? No, it's intended to stop trying to send further invitation messages once we get back false. The return value indicates users choice on the compatibility popup on sending/not sending the invitation (and not the effective result of sending - even if sending out fails for e.g. due to network time out, it would return true). That said, we should stop sending messages, otherwise we would end up in scenario quit opposite to the one, this bug should address: on user cancelled send out, we would send out invitation to each but the first attendee.
(In reply to MakeMyDay from comment #3) > (In reply to Philipp Kewisch [:Fallen] from comment #2) > > > > Shouldn't we unconditionally be sending the messages and returning true iff > > all of them have been sent? > > No, it's intended to stop trying to send further invitation messages once we > get back false. > > The return value indicates users choice on the compatibility popup on > sending/not sending the invitation (and not the effective result of sending > - even if sending out fails for e.g. due to network time out, it would > return true). That said, we should stop sending messages, otherwise we would > end up in scenario quit opposite to the one, this bug should address: on > user cancelled send out, we would send out invitation to each but the first > attendee. Ok, makes sense. Another question then, does this mean there will be one popup per attendee when using this option?
No, only the first attempt to send an invitation message will show the popup (this is triggered by the autoResponse attribute of the ItipItem, set to true after the initializing the first invitation mesaage to send). For check in: we should backport this to 3.2, otherwise the invitation functionality is broken there under conditions of this bug.
Comment on attachment 8395269 [details] [diff] [review] SendUndiclosedToAllAttendees-V1.diff Ok, thanks for the info. Then lets have it pushed :)
Attachment #8395269 - Flags: approval-calendar-aurora+
Target Milestone: --- → 3.2
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: