Closed
Bug 986972
Opened 11 years ago
Closed 6 years ago
do_QueryInterface abuse in nsDocument.cpp
Categories
(Core :: DOM: Core & HTML, defect, P5)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
WORKSFORME
People
(Reporter: neil, Unassigned)
References
Details
The code
nsCOMPtr<css::Rule> rule = do_QueryInterface(aNewStyleRule);
which appears several times in nsDocument.cpp is an abuse of do_QueryInterface, since css::Rule is not an interface, so what happens is that aNewStyleRule gets reinterpreted as a css::Rule*.
aNewStyleRule should probably be changed to be a css::Rule* directly.
|
Reporter | |
Comment 2•11 years ago
|
||
Sorry, I must have asked the wrong person about whether that bug had been filed already.
|
||
Updated•6 years ago
|
Priority: -- → P5
|
||
Comment 3•6 years ago
|
||
No code matching the description in comment 0 exists now, AFAICT.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WORKSFORME
|
Assignee | |
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•