Closed
Bug 986973
Opened 11 years ago
Closed 3 years ago
do_GetService abuse in ContentParent.cpp
Categories
(Core :: DOM: Content Processes, defect, P5)
Core
DOM: Content Processes
Tracking
()
RESOLVED
FIXED
100 Branch
| Tracking | Status | |
|---|---|---|
| firefox100 | --- | fixed |
People
(Reporter: neil, Assigned: saschanaz)
References
Details
Attachments
(1 file)
|
(deleted),
text/x-phabricator-request
|
Details |
The code
nsCOMPtr<nsConsoleService> consoleService(do_GetService(consoleServiceCID));
which appears ContentParent.cpp is an abuse of do_GetService, since nsConsoleService is not an interface, so what happens is that the nsIConsoleService pointer gets reinterpreted as an nsConsoleService*.
consoleService should probably be changed to an nsCOMPtr<nsIConsoleService>, and then mConsoleService should be statically cast from consoleService.get().
|
||
Updated•10 years ago
|
Component: IPC → DOM: Content Processes
|
||
Comment 1•6 years ago
|
||
https://bugzilla.mozilla.org/show_bug.cgi?id=1472046
Move all DOM bugs that haven’t been updated in more than 3 years and has no one currently assigned to P5.
If you have questions, please contact :mdaly.
Priority: -- → P5
|
Assignee | |
Comment 2•3 years ago
|
||
D132270 removed the problematic line, so it's not needed anymore.
|
||
Updated•3 years ago
|
Assignee: nobody → krosylight
Status: NEW → ASSIGNED
Pushed by krosylight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5cbfa9fc80d2
Remove nsConsoleService hack in ContentParent r=smaug
|
||
Comment 4•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox100:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•