Closed Bug 98704 Opened 23 years ago Closed 23 years ago

Node::getXPathParent is needed all over the place, ContextState::getParentNode should die

Categories

(Core :: XSLT, defect, P1)

Product:
Core
Component:
XSLT
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla0.9.5

People

(Reporter: axel, Assigned: axel)

References

Details

Attachments

(2 files)

getXPathParent.patch
(deleted), patch
peterv
: review+
brendan
: superreview+
Details | Diff | Splinter Review
second patch, kill ProcessorState::getParentNode alltogether
(deleted), patch
sicking
: review+
jst
: superreview+
Details | Diff | Splinter Review
This bug is a split off from bug 76070. The upcoming patch implements Node::getXPathParent, does the right thing to source/xml/util/DOMHelper, and fixes the whitespace mess in NodeDefinition::getBaseURI (just as I go). Axel
Status: NEW → ASSIGNED
Keywords: review
Priority: -- → P1
Target Milestone: --- → mozilla0.9.5
Attached patch getXPathParent.patch (deleted) — — Splinter Review
Blocks: 76070, 94471
No longer blocks: 76070
Blocks: 76070
Comment on attachment 48577 [details] [diff] [review] getXPathParent.patch r=peterv, now on to killing ProcessorState::getParentNode
Attachment #48577 - Flags: review+
Comment on attachment 48577 [details] [diff] [review] getXPathParent.patch rs=brendan@mozilla.org
Attachment #48577 - Flags: superreview+
patch 48577 is in, leaving this bug open and morping it to kill ContextState::getParentNode (which is ProcessorState::getParentNode). Axel
Summary: Node::getXPathParent is needed all over the place → Node::getXPathParent is needed all over the place, ContextState::getParentNode should die
added MBool LocationStep::matches(Node* node, Node* context, ContextState* cs) { - if ( !nodeExpr ) return MB_FALSE; + if (!nodeExpr || !node) + return MB_FALSE; - if ( !nodeExpr->matches(node, context, cs) ) return MB_FALSE; + if (!nodeExpr->matches(node, context, cs)) + return MB_FALSE; to make ::matches 0 crash safe. Thanx to sicking for catching this. (the second one is just whity fun) Axel
Comment on attachment 49080 [details] [diff] [review] second patch, kill ProcessorState::getParentNode alltogether r=sicking
Attachment #49080 - Flags: review+
Comment on attachment 49080 [details] [diff] [review] second patch, kill ProcessorState::getParentNode alltogether r=peterv
Comment on attachment 49080 [details] [diff] [review] second patch, kill ProcessorState::getParentNode alltogether sr=jst
Attachment #49080 - Flags: superreview+
I forgot to note in the first landing that this is code by sicking, sorry for that. second stage landed, marking fixed. Axel
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: