STR: Open camera and record a short video. Open Gallery. Play the video. Seems to me like a reflow happens every time the seek bar moves.

I can see the same effect in Gaia::Video while the player chrome is visible.

This removes the reflows on playHead and elapsedTime, and makes elapsedText only reflow when it's being updated. See GitHub for comments on the way code has been changed.

Comment on attachment 8395688 [details] Patch Passing on to David to take or pass on to relevant media peer, I dont work on media apps any more. Cheers

Comment on attachment 8395688 [details] Patch Passing this review to John.

Jan, Thanks for the patch and for your helpful github comments explaining the patch. I think some of those comments are worth putting in the code itself. Also, could you clarify whether this bug is about reflows or repaints? If reflows, how are they detected, and how can John detect them so that he can verify that this patch prevents them?

Jan, Also, note that this bug is filed against Gallery, but that your patch fixes only the Video app. And also, the video app has (or had) two different players: it uses different code when invoked via an activity than it does when invoked normally. So I think that you may need to repeat your fixes two more times for gallery and for the other video player. The camera app can also play videos and probably has reflow issues as well, but that should probably be handled in a separate bug because there is lots of work on Camera right now.

Alright, let's move the component to Video and see if this gets r+'ed first. Then I'll move some of the comments inline and track down the same issue in the other apps.

Reflows are detected by connecting the App Manager, then toggling 'Info' under the CSS menu in console.

Comment on attachment 8395688 [details] Patch Jan, Thanks for your comment 8 and this patch. After applying the patch, I still see the reflow information when I drag the slider bar. I am not expert on this part. I found the slider bar doesn't get repainted but only the affected area of playHead and played bar get repainted when I tested with 'Flash repainted area' enabled. So, it does eliminate some the repaint jobs and I would like to land this patch. I reset the review flag because this patch breaks our tablet version where the playHead doesn't catch the finger when we try to drag it. I will upload an image here. For people without tablet, we may use the firefox nightly to test it. Please follow this video to test it: https://www.youtube.com/watch?v=msxoj0m5HQc

Firefox OS is not being worked on