Closed
Bug 987385
Opened 11 years ago
Closed 8 years ago
Plugin IPC leaks in Mochitest-plain
Categories
(Core Graveyard :: Plug-ins, defect, P3)
Tracking
(Not tracked)
RESOLVED
WORKSFORME
People
(Reporter: mccr8, Unassigned)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
I don't remember seeing these before, but that just may mean that they show up now because I improved the stack. These occur in a number of functions, such as mozilla::plugins::DeferNPObjectLastRelease, mozilla::plugins::PluginScriptableObjectChild::ScriptableEnumerate, mozilla::plugins::PPluginInstanceParent::CallNPP_HandleEvent, mozilla::plugins::PPluginModule::Reply_ProcessSomeEvents::Reply_ProcessSomeEvents. These may actually be a number of different leaks. The latter two look very IPC-y.
Reporter | ||
Comment 1•11 years ago
|
||
Here are some more, in crashtests. They are small, and look a little different than the other ones.
Updated•11 years ago
|
Flags: firefox-backlog?
Priority: -- → P3
Updated•11 years ago
|
Flags: firefox-backlog? → firefox-backlog+
Reporter | ||
Comment 2•11 years ago
|
||
Some more, from M3:
Direct leak of 48 byte(s) in 1 object(s) allocated from:
#0 0x471d41 in malloc /builds/slave/moz-toolchain/src/llvm/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:74
#1 0x7fa341020bed in moz_xmalloc /build/memory/mozalloc/mozalloc.cpp:52
#2 0x7fa32e07233f in operator new /build/obj-firefox/ipc/ipdl/../../dist/include/mozilla/mozalloc.h:201
#3 0x7fa32e07233f in mozilla::plugins::PPluginModuleParent::OnCallReceived(IPC::Message const&, IPC::Message*&) /build/obj-firefox/ipc/ipdl/./PPluginModuleParent.cpp:1462
#4 0x7fa32dbf8fdd in mozilla::ipc::MessageChannel::DispatchInterruptMessage(IPC::Message const&, unsigned long) /build/ipc/glue/MessageChannel.cpp:1217
#5 0x7fa32dbf7139 in mozilla::ipc::MessageChannel::InterruptCall(IPC::Message*, IPC::Message*) /build/ipc/glue/MessageChannel.cpp:881
Indirect leak of 64 byte(s) in 1 object(s) allocated from:
#0 0x471fbb in realloc /builds/slave/moz-toolchain/src/llvm/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:95
#1 0x7fa32dbbb766 in Resize /build/ipc/chromium/src/base/pickle.cc:617
#2 0x7fa32dbbb766 in Pickle::Pickle(int) /build/ipc/chromium/src/base/pickle.cc:118
#3 0x7fa32dbca505 in IPC::Message::Message(int, unsigned int, IPC::Message::PriorityValue, IPC::Message::MessageCompression, char const*) /build/ipc/chromium/src/chrome/common/ipc_message.cc:44
#4 0x7fa32e072363 in operator new /build/obj-firefox/ipc/ipdl/_ipdlheaders/mozilla/plugins/PPluginModule.h:993
#5 0x7fa32e072363 in mozilla::plugins::PPluginModuleParent::OnCallReceived(IPC::Message const&, IPC::Message*&) /build/obj-firefox/ipc/ipdl/./PPluginModuleParent.cpp:1462
#6 0x7fa32dbf8fdd in mozilla::ipc::MessageChannel::DispatchInterruptMessage(IPC::Message const&, unsigned long) /build/ipc/glue/MessageChannel.cpp:1217
Comment 3•10 years ago
|
||
Do we have any documentation yet on how to build with LSAN?
Flags: needinfo?(continuation)
Reporter | ||
Comment 4•10 years ago
|
||
(In reply to Georg Fritzsche [:gfritzsche] from comment #3)
> Do we have any documentation yet on how to build with LSAN?
Ah, good point, I should do that! Basically, it is just a regular ASan build with some extra environment variables set. See the new section I just added at the end of this Wiki article:
https://developer.mozilla.org/en-US/docs/Mozilla/Testing/Firefox_and_Address_Sanitizer
Flags: needinfo?(continuation)
Reporter | ||
Updated•10 years ago
|
Summary: More plugin leaks found by LSAN → Plugin IPC leak under PPluginModuleParent::OnCallReceived
Reporter | ||
Comment 5•10 years ago
|
||
Err, ok, the leaks are actually under PPluginInstanceParent::CallNPP_HandleEvent and PPluginModuleParent::OnCallReceived. Some of the stacks here are kind of out of date. These are from m3. I'll try to narrow them down a bit.
Summary: Plugin IPC leak under PPluginModuleParent::OnCallReceived → Plugin IPC leaks in Mochitest-plain
Comment 6•8 years ago
|
||
This leak appears to be gone now. The suppression was removed in bug 1311584.
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → WORKSFORME
Updated•2 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•