Closed
Bug 987389
Opened 11 years ago
Closed 11 years ago
[Clock] Make timer dialog spin buttons accessible
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: eeejay, Assigned: eeejay)
References
Details
(Keywords: access)
Attachments
(2 files)
Do something similar to the time selector in the system app.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #8395991 -
Flags: review?(m)
Comment 2•11 years ago
|
||
Comment on attachment 8395991 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/17549
Woohoo. I tested it locally and it still seems to work, but I don't know how to work the screen reader, so I'm assuming that that part works as you intended. r=mcav! Thanks!
Attachment #8395991 -
Flags: review?(m) → review+
Assignee | ||
Comment 3•11 years ago
|
||
(In reply to Marcus Cavanaugh [:mcav] <mcav@mozilla.com> from comment #2)
> Comment on attachment 8395991 [details]
> Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/17549
>
> Woohoo. I tested it locally and it still seems to work, but I don't know how
> to work the screen reader, so I'm assuming that that part works as you
> intended. r=mcav! Thanks!
Thanks! I highly encourage you to give the screen reader a spin and see for yourself.
Assignee | ||
Comment 4•11 years ago
|
||
Assignee: nobody → eitan
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 5•11 years ago
|
||
Reverted due to unit test failures: https://github.com/mozilla-b2g/gaia/commit/b08b7f8e24867a58f7ce55e23c19498d411ef165
Please ensure travis is green before merging any pull request. Thanks!
1) [clock] Spinner values: [0, 1, 2] "before each" hook:
TypeError: this.textValues is undefined
at Spinner (http://clock.gaiamobile.org:8080/js/picker/spinner.js?cache_bust=1395771528618:113:5)
at (anonymous) (http://clock.gaiamobile.org:8080/test/unit/picker/spinner_test.js:100:1)
at wrapper (http://clock.gaiamobile.org:8080/common/test/mocha_generators.js:62:13)
at run (http://clock.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3709:7)
at next (http://clock.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3973:5)
at (anonymous) (http://clock.gaiamobile.org:8080/common/vendor/mocha/mocha.js:3984:5)
at (anonymous) (http://clock.gaiamobile.org:8080/common/vendor/mocha/mocha.js:4932:28)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Assignee | ||
Comment 6•11 years ago
|
||
Fixed patch to pass unit test. Lets see if travis is happy..
Assignee | ||
Comment 7•11 years ago
|
||
Comment on attachment 8396665 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/17601
Travis is reporting a failure in an unrelated unit test from another app.
Attachment #8396665 -
Flags: review?(m)
Comment 8•11 years ago
|
||
Comment on attachment 8396665 [details]
Link to Github pull-request: https://github.com/mozilla-b2g/gaia/pull/17601
Okay, after a couple reloads, Travis passes -- looks OK to me.
Attachment #8396665 -
Flags: review?(m) → review+
Assignee | ||
Comment 9•11 years ago
|
||
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
Comment 10•11 years ago
|
||
Is there a specific reason for this inconsistency: one second, one minute, 1 hour?
You need to log in
before you can comment on or make changes to this bug.
Description
•