Closed Bug 987403 Opened 11 years ago Closed 10 years ago

Enable gzip on commonplace index.html

Categories

(Marketplace Graveyard :: Consumer Pages, defect, P3)

defect

Tracking

(Not tracked)

VERIFIED FIXED
2014-09-30

People

(Reporter: cvan, Assigned: mat)

References

()

Details

(Keywords: perf)

No description provided.
We could get a 66% reduction in document size.
Keywords: perf
Priority: -- → P3
Wouldn't we want to enable gzip everywhere? Or at least on all text documents (HTML, CSS, JavaScript)? I'm assuming this would be an nginx configuration that would go in here: https://github.com/mozilla-services/svcops-puppet/blob/master/modules/marketplace/templates/nginx/marketplace.conf#L184
(In reply to Dethe Elza [:dethe] from comment #2) > Wouldn't we want to enable gzip everywhere? Or at least on all text > documents (HTML, CSS, JavaScript)? > > I'm assuming this would be an nginx configuration that would go in here: > https://github.com/mozilla-services/svcops-puppet/blob/master/modules/ > marketplace/templates/nginx/marketplace.conf#L184 We are already gzipping all text (CSS, JavaScript, JSON) on the CDN on prod: %% curl 'https://marketplace.cdn.mozilla.net/media/fireplace/css/include.css?b=1396521250112' -H 'Accept-Encoding: gzip,deflate,sdch' -I HTTP/1.1 200 OK ... Content-Encoding: gzip ... And on the CDN on -dev: %% curl 'https://marketplace-dev.mozflare.net/media/fireplace/css/include.css?b=1396522545259' -H 'Accept-Encoding: gzip,deflate,sdch' -I HTTP/1.1 200 OK ... Content-Encoding: gzip On -dev, previously assets were being served from Zamboni, not the CDN, so yeah modifying the nginx conf file for -dev would be great for that. I had asked Jason to do it a while back, so yeah a pull request for that would be great.
No longer blocks: tarako-marketplace
Blocks: 992365
No longer blocks: 992365
Assignee: nobody → mpillard
https://github.com/mozilla/zamboni/pull/2576 Note that we don't enable gzip on other HTML documents deliberately, because of BREACH [0]. However, commonplace pages are not supposed to contain secrets, so we can enable gzip here. [0] http://breachattack.com/
Status: NEW → ASSIGNED
Target Milestone: --- → 2014-09-30
Fixed in https://github.com/mozilla/zamboni/commit/5c561ef2973aeb335e07c1048b8e4cc73cf93a5b STR: - Load https://marketplace-dev.allizom.org/ in your browser with developer tools network opened (HTML tab). - Check that 'Content-Encoding: "gzip"' is present in the response headers for the "/" page. - Check that the page displays normally. - Check that 'Content-Encoding: "gzip"' is also present in the response headers for the "iframe-install.html" page. Note: clear your browser cache beforehand or Ctrl+Shift+R if you don't see the requests.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Verified as fixed in FF35(Win7) in marketplace-dev.alliom.org Postfix screencast: http://screencast.com/t/4YrkL0vqOqJp Closing.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.