Closed Bug 987419 Opened 11 years ago Closed 11 years ago

Update copy in fxa panel within FTE

Categories

(Firefox OS Graveyard :: FxA, defect)

Product:
Firefox OS Graveyard
Component:
FxA
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v2.0 fixed)

Status:
RESOLVED FIXED
Milestone:
2.0 S1 (9may)
Tracking Flags:
Tracking Status
b2g-v2.0 --- fixed

People

(Reporter: jhirsch, Unassigned)

References

Details

Attachments

(1 file, 1 obsolete file)

Github PR 17675
(deleted), text/x-github-pull-request
arcturus
: review+
Details
Per spec uploaded in bug 960130, the copy should read: "Use your email address to create an account or sign in."
Blocks: 987416
QA Contact: 6a68
Whoops, my description was incorrect. see the pull request for the actual phrase changed :-P
Attached file Github PR 17612 (obsolete) (deleted) —
Attachment #8396835 - Flags: review?(francisco.jordano)
Sorry for reiterating the comment over 3 bugs, but I want to be sure reviewers see it. https://developer.mozilla.org/en-US/docs/Making_String_Changes This rule applies to Gaia as well. So, please, get the copy checked before landing code.
Comment on attachment 8396835 [details] Github PR 17612 As commented before, there are some rules for string changing. If I'm not wrong, you should name your string <string>2 or <string>3, depending the times the string changed. That will help translators to know what's going on with that specific string and that they have to change it. Thanks! F.
Attachment #8396835 - Flags: review?(francisco.jordano) → review-
PS: the suffix number is a hack if you're not having a good new name. In general, the strings should have names as if they were variables, with good semantic meaning. Which, if the semantics of a string change, often suggests the new name. In this case of just broken copy, doesn't help us much.
(In reply to Axel Hecht [:Pike] from comment #5) > PS: the suffix number is a hack if you're not having a good new name. In > general, the strings should have names as if they were variables, with good > semantic meaning. > > Which, if the semantics of a string change, often suggests the new name. > > In this case of just broken copy, doesn't help us much. Thanks for the clarification Axel!
:flod I don't understand what exactly is so different about the string here. What would you suggest I change the tag to? fxa-intro2?
Flags: needinfo?(francesco.lodolo)
ah wait, I get it! anything different, even a synonym (I looked more closely at the l10n git history).
Flags: needinfo?(francesco.lodolo)
Attached file Github PR 17675 (deleted) —
I typo'd the bug number in the first PR, reopened to fix that. Also addressed the review feedback
Attachment #8396835 - Attachment is obsolete: true
Attachment #8397455 - Flags: review?(francisco.jordano)
Comment on attachment 8397455 [details] Github PR 17675 Thanks Jared! Could you squash the commits into one and merge?
Attachment #8397455 - Flags: review?(francisco.jordano) → review+
Squashed, Travis is happy, merging.
Master: https://github.com/mozilla-b2g/gaia/commit/b7a304a173a0b7e0fdd201efb788b20c5bea0267
Status: NEW → RESOLVED
Closed: 11 years ago
status-b2g-v2.0: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 1.5 S1 (9may)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: