Closed
Bug 98749
Opened 23 years ago
Closed 22 years ago
Bookmark keyword substitution only work on the first token
Categories
(SeaMonkey :: Bookmarks & History, defect, P5)
SeaMonkey
Bookmarks & History
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 124237
Future
People
(Reporter: peter, Assigned: bugs)
References
Details
If I use the keyword substitution feature of bookmarks it will only substitute
text for the first token in the location string. For example, let's create a
bookmark for Bugzilla that searches a number of fields:
Name: Mozilla Bugzilla
Location:
http://bugzilla.mozilla.org/buglist.cgi?bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&field0-0-0=product&type0-0-0=substring&value0-0-0=%s&field0-0-1=component&type0-0-1=substring&value0-0-1=%s&field0-0-2=short_desc&type0-0-2=substring&value0-0-2=%s&field0-0-3=status_whiteboard&type0-0-3=substring&value0-0-3=%s
Keyword: mozbug
Notice that there are four places where I use the substitution token, %s.
Now, let's do a query using the bookmark. I enter the following into the
Location field in the browser:
mozbug XXXXXXXXXX
The resulting value in the Location field is:
http://bugzilla.mozilla.org/buglist.cgi?bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&field0-0-0=product&type0-0-0=substring&value0-0-0=XXXXXXXXXX&field0-0-1=component&type0-0-1=substring&value0-0-1=%25s&field0-0-2=short_desc&type0-0-2=substring&value0-0-2=%25s&field0-0-3=status_whiteboard&type0-0-3=substring&value0-0-3=%25s
Notice that the first substitution token is correctly replaced. But the
remaining three tokens are replaced with '%25s'.
Assignee | ||
Updated•23 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → Future
Assignee | ||
Comment 1•23 years ago
|
||
Paul Chen is now taking Bookmarks bugs. For your convenience, you can filter
email notifications caused by this by searching for 'ilikegoats'.
Assignee: ben → pchen
Status: ASSIGNED → NEW
Mass move Ben's bugs dumped on me marked future with p5 to get off my untriaged
radar. You can filter out this email by looking for "ironstomachaussie"
Priority: -- → P5
*** Bug 124237 has been marked as a duplicate of this bug. ***
bug 124237 was marked a duplicate of this one, and I think this was done
incorrectly.
This bug asks only for multiple %s tokens to be filled in (with the entire query
text), but bug 124237 asks for that and more (and provides perl code as a
starting point). In particular, it asks for you to be able to
keyword argA argB argC
and have those args put in the proper (different) locations in your resulting URL.
So, as this bug asks for less, I don't see bug 124237 as a duplicate of this
one. Note however, that if someone tackles bug 124237 first, the method used
there will address what's requested in this bug. There's sample code in perl
that could get someone started.
-matt
OS: Linux → All
Hardware: PC → All
*** Bug 124173 has been marked as a duplicate of this bug. ***
this bug blocks bug 123006. Note that both this bug *and* bug 123006 would be
fixed by implementing RFE bug 124237.
this bug can be fixed by something from bug 124240
http://bugzilla.mozilla.org/show_bug.cgi?id=124240
"custom keyword queries need terminated tokens before mozilla 1.0"
which has a simple patch touching only two lines
http://bugzilla.mozilla.org/attachment.cgi?id=74399&action=view
"patch incorporates 74320 and also fixes bug 98749"
that patch fixes its bug *and* this one.
-matt
Comment 9•22 years ago
|
||
I could set this bug to block bug 124237, then again bug 124237
is ASSIGNED and this bug is NEW, and fix to bug 124237 supposedly
fix this bug
--> duplicate
*** This bug has been marked as a duplicate of 124237 ***
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → DUPLICATE
Updated•20 years ago
|
Product: Browser → Seamonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•