Terrence Cole [:terrence] Assignee
	Description • 10 years ago

I think I got all of it?

	Steve Fink [:sfink] [:s:]
	Comment 1 • 10 years ago

Comment on attachment 8396360 [details] [diff] [review]
rm_root_analysis-v0.diff

Review of attachment 8396360 [details] [diff] [review]:
-----------------------------------------------------------------

Wow. I had no idea that had crept into so much stuff!

	Steve Fink [:sfink] [:s:]
	Comment 2 • 10 years ago

Comment on attachment 8396360 [details] [diff] [review]
rm_root_analysis-v0.diff

Review of attachment 8396360 [details] [diff] [review]:
-----------------------------------------------------------------

Wow. I had no idea that had crept into so much stuff!

Ok. I really need to go to sleep. I meant r+, not r- !

	Terrence Cole [:terrence] Assignee
	Comment 3 • 10 years ago

Rebased to tip. Final diffstat:

  40 files changed, 22 insertions(+), 653 deletions(-)

	Ryan VanderMeulen [:RyanVM]
	Comment 4 • 10 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/fbca45e65930

	Terrence Cole [:terrence] Assignee
	Comment 5 • 10 years ago

OMG, SkipRoot leaked into the browser!?!

	Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)
	Comment 6 • 10 years ago

https://hg.mozilla.org/mozilla-central/rev/fbca45e65930
https://hg.mozilla.org/mozilla-central/rev/a926b8938e9a

	Terrence Cole [:terrence] Assignee
	Comment 7 • 10 years ago

I missed the IsPoisoned assertions. 150 lines worth of them. Spread all over the place. Hopefully that's the last for real this time.

https://tbpl.mozilla.org/?tree=Try&rev=e838e744545e

	Terrence Cole [:terrence] Assignee
	Comment 8 • 10 years ago

https://tbpl.mozilla.org/?tree=Try&rev=e41b2d977d63

Gah! That leaked into the browser too.

	Terrence Cole [:terrence] Assignee
	Comment 9 • 10 years ago

Comment on attachment 8399463 [details] [diff] [review]
missed_some_root_analysis_removal-v0.diff

We discussed this at the GC meeting today and decided to convert these sites over to JS_CRASH_DIAGNOSTICS.

	Florian Bender
	Comment 10 • 10 years ago

Terrence, what's the status here? Does any of this need uplifting for 31 (incl. wrt maintainability for ESR)?

	Terrence Cole [:terrence] Assignee
	Comment 11 • 10 years ago

I think we only bits from the prior patch we wanted to keep was removal from configure.in. Here is a patch to do that removal.

	Terrence Cole [:terrence] Assignee
	Comment 12 • 10 years ago

https://hg.mozilla.org/integration/mozilla-inbound/rev/51563b7c1a8f

	Carsten Book [:Tomcat]
	Comment 13 • 10 years ago

https://hg.mozilla.org/mozilla-central/rev/51563b7c1a8f