Paul Silaghi, QA [:pauly] Reporter
	Description • 10 years ago

STR:
1. Open Firefox
2. Open File/New Private Window
3. Open 2 tabs
4. Close the private window

AR: No warning
FF 29b2, 31.0a1(2014-03-25), Win 7 x64

	Paul Silaghi, QA [:pauly] Reporter
	Comment 1 • 10 years ago

Not a regression of bug 884355, repro on Nightly 24.0a1 2013-06-18

	Josh Matthews [:jdm]
	Comment 2 • 10 years ago

I'm pretty sure this is intentional; we want to make closing private windows as quick as possible, and dialogs interfere with that.

	Paul Silaghi, QA [:pauly] Reporter
	Comment 3 • 10 years ago

Then grey out the warning pref. There can't be an available pref which does nothing.

	Josh Matthews [:jdm]
	Comment 4 • 10 years ago

Sorry, what's the "warning pref" you're talking about?

	Paul Silaghi, QA [:pauly] Reporter
	Comment 5 • 10 years ago

Tools/Options/Tabs/Warn me when closing multiple tabs

	Josh Matthews [:jdm]
	Comment 6 • 10 years ago

We're only talking about temporary private windows in this bug right? "Never remember history" mode is entirely different, but the option to warn on closing tabs relates to non-private windows.

	Paul Silaghi, QA [:pauly] Reporter
	Comment 7 • 10 years ago

(In reply to Josh Matthews [:jdm] from comment #6)
> We're only talking about temporary private windows in this bug right? 
Yes

	Graeme Hewson
	Comment 8 • 10 years ago

If the original, non-private window is closed, so only the private window with two tabs is open, a warning is given if you attempt to close the private window.

31.0a1 (2014-03-26)

	Josh Matthews [:jdm]
	Comment 9 • 10 years ago

This all sounds like it's working as intended. We can't do anything about the warning option in the preferences.

	(no longer active)
	Comment 10 • 10 years ago

(In reply to comment #8)
> If the original, non-private window is closed, so only the private window with
> two tabs is open, a warning is given if you attempt to close the private
> window.

That sounds like a bug to me.

	Graeme Hewson
	Comment 11 • 10 years ago

(In reply to Josh Matthews [:jdm] from comment #6)
> the option to warn on
> closing tabs relates to non-private windows.

Nowhere is this stated. It's not stated in the option setting, the help, or the text in the initial private browsing window. The fact that a private browsing window can be closed without warning is a surprise to the user.

	Paul Silaghi, QA [:pauly] Reporter
	Comment 12 • 10 years ago

(In reply to Graeme Hewson from comment #8)
> If the original, non-private window is closed, so only the private window
> with two tabs is open, a warning is given if you attempt to close the
> private window.
> 
> 31.0a1 (2014-03-26)
And if the original, non-private window is not closed, when closing the private window the multiple tabs warning doesn't show up.

(In reply to Josh Matthews [:jdm] from comment #9)
> This all sounds like it's working as intended. 
Not honoring a valid pref when it's checked sounds like a valid bug to me.
> We can't do anything about the warning option in the preferences.
How about to make the warning show up for private windows too ?

	Troy W.
	Comment 14 • 10 years ago

(In reply to Paul Silaghi, QA [:pauly] from comment #7)
> (In reply to Josh Matthews [:jdm] from comment #6)
> > We're only talking about temporary private windows in this bug right? 
> Yes

Then 952925 is not a duplicate of this bug. The problem occurs when the Enable Private Browsing Mode preference is enabled.

	Ben
	Comment 16 • 10 years ago

(In reply to Josh Matthews [:jdm] from comment #2)
> I'm pretty sure this is intentional; we want to make closing private windows
> as quick as possible, and dialogs interfere with that.

Are you saying this is definitely intended behaviour, or are you just guessing?

Private Browsing sessions cannot be restored.  Of all the instances where the user (who has checked the pref) wants to receive the warning prompt this has to be the most important.  Where does this idea of “temporary private windows” come from?  How do you come to the conclusion that just because a user has chosen to begin a private session they do not care about it?

Private sessions are not just handy for 14-yo boys who don’t want their mums catching them viewing dodgy sites (the only scenario I can conceive where a user might literally want their session to disappear forever at a single click!)  They are very useful for logging into sites with two accounts simultaneously (because the cookies aren’t shared between the two windows), ie to check two Gmail accounts.  Because there is no option given to open a link that’s in a Private window in a non-private one there’s every chance of ending up with a fairly sizeable session.

But even if it was just two tabs there is no logical reason not to try and protect it.  Note that the ‘close multiple tabs’ warning includes a checkbox called “Warn me when I attempt to close multiple tabs”.  A user who doesn’t like the prompts doesn’t even need to find the right box in Options – they just uncheck that and they’ll never see one again.

Users who want to receive the warning for normal windows will also want / expect to get one for private ones.  To not present it is either a bug or a mistake.

	Josh Matthews [:jdm]
	Comment 17 • 10 years ago

It is intended behaviour, per bug 854926. It's also clear that there is not a unanimous desire for one behaviour over the other.