With the help of ARM Mali guys at GDC and bjacob, we found out that the function GLContextEGL::MakeCurrentImpl in GLContextProviderEGL.cpp always calls eglGetError() after each operation, which shows up in api trace tools as a eglGetError() function call after each GL function. Looking at the code, this seems to be accidental and not always necessary.

Move the check to inside scope to avoid always calling to eglGetError().

Comment on attachment 8396534 [details] [diff] [review] 987845-avoid-eglgeterror.patch Review of attachment 8396534 [details] [diff] [review]: ----------------------------------------------------------------- Thanks for catching this! You will want to push this to try before landing, because calling getError has the side effect of clearing the error flag, so if you're sufficiently unlucky you might get a test failure. Once this is landed, we'll probably want to backport this at least to aurora and B2G 1.4.

Ok, I'm blocked on this for a while, since this is actually my first Firefox-side patch and I'm now waiting to get a SSH public key added via servicedesk. I'll do a try once I've got the key set up.

Comment on attachment 8396534 [details] [diff] [review] 987845-avoid-eglgeterror.patch Review of attachment 8396534 [details] [diff] [review]: ----------------------------------------------------------------- I want to r+ this too, because that was really silly of us.

Anyone else wants to r+ before we land? Try is green, and, what is more remarkable, inbound is currently open...

Comment on attachment 8396534 [details] [diff] [review] 987845-avoid-eglgeterror.patch [Approval Request Comment] Bug caused by (feature/regressing bug #): Not sure; may not be a regression. User impact if declined: Unnecessary graphics inefficiency (performance problems, depending on driver) Testing completed (on m-c, etc.): m-c for a couple of days. Risk to taking this patch (and alternatives if risky): Zero risk, trivial patch. String or IDL/UUID changes made by this patch: none

https://hg.mozilla.org/releases/mozilla-aurora/rev/27349a797425 Lukas: I think that this should be taken in B2G 1.4. How do I achieve that? (I don't see a tracking-b2g-v1.4 flag).

Aurora = v1.4