Investigate whether ActivityHandler.isLocked is still required for the 'new' and 'share' activity. Get rid of it in case we don't need it anymore.

Let's finally deal with this :)

Comment on attachment 8549195 [details] GitHub pull request URL Hey Steve, can you please have a look at this simple patch? Thanks !

Comment on attachment 8549195 [details] GitHub pull request URL Thanks for the clean up, I think we don't need this since all the new activity is inline now. BTW I discover an edge case unrelated to this patch(related to new activity) will lead the message app crashed: 1) Contact -> detail -> send message -> Back to home at compose panel 2) Phone -> switch to contact tab -> send another message from contact 3) Message app crashed It's not related to the patch because it just crashed without reaching the activity-handler at second time. Just wondering if you could reproduce this as well.

Hi Alive, we discover a crash issue in comment 3. Is there any known issue about calling new inline activity repeatedly?

(In reply to Steve Chung [:steveck] from comment #4) > Hi Alive, we discover a crash issue in comment 3. Is there any known issue > about calling new inline activity repeatedly? https://bugzilla.mozilla.org/show_bug.cgi?id=931339 ? System app should kill the first activity before the second activity chaining starts, but I suspect it failed to understand the second contact is not the first contact..

(In reply to Steve Chung [:steveck] from comment #3) > Comment on attachment 8549195 [details] > GitHub pull request URL > > Thanks for the clean up, I think we don't need this since all the new > activity is inline now. BTW I discover an edge case unrelated to this > patch(related to new activity) will lead the message app crashed: > > 1) Contact -> detail -> send message -> Back to home at compose panel > 2) Phone -> switch to contact tab -> send another message from contact > 3) Message app crashed > > It's not related to the patch because it just crashed without reaching the > activity-handler at second time. Just wondering if you could reproduce this > as well. Yep, I see the same issue and looks like it's related to bug 931339 - when we open Messages as inline activity the second time it doesn't receive "activity" system message at all and we can stuck in half-initialized app. And it seems in my case the first activity instance crashed.

Thanks for review! Treeherder is green except for one unrelated and known intermittent. Master: https://github.com/mozilla-b2g/gaia/commit/2e22ab55444c418410a7eb4a1a044834777566b9