Closed Bug 988457 Opened 11 years ago Closed 11 years ago

make loop-client shared directory authoritative

Categories

(Hello (Loop) :: Client, defect)

Product:
Hello (Loop)
Component:
Client
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla33

People

(Reporter: dmosedale, Assigned: dmosedale)

References

Details

Attachments

(1 file, 1 obsolete file)

Link to Github pull-request: https://github.com/adamroach/gecko-dev/pull/7
(deleted), text/x-github-pull-request
standard8
: review+
Details
No description provided.
Attachment #8397256 - Flags: review?(standard8)
Note that I expect a client build to work with these changes, but I haven't yet verified.
Assignee: nobody → dmose
Comment on attachment 8397256 [details] Link to Github pull-request: https://github.com/mozilla/gecko-dev/pull/19 This appears to be trying to pull into mozilla:master, not adamroach:loop-ui-initial. When I do the comparison: https://github.com/adamroach/gecko-dev/compare/loop-ui-initial...share-switch I don't see the README that you've said you've added; otherwise I'd re-create it.
Attachment #8397256 - Flags: review?(standard8) → review-
Attachment #8397256 - Attachment is obsolete: true
Attachment #8397413 - Flags: review?(standard8)
Comment on attachment 8397413 [details] Link to Github pull-request: https://github.com/adamroach/gecko-dev/pull/7 Looks good, r=Standard8
Attachment #8397413 - Flags: review?(standard8) → review-
Attachment #8397413 - Flags: review- → review+
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla33
Assuming verified -- please needinfo me to request QA testing.
Status: RESOLVED → VERIFIED
QA Contact: anthony.s.hughes
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: