Closed
Bug 988530
Opened 11 years ago
Closed 10 years ago
banner lifetime is too long
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(b2g-v2.2 fixed, b2g-master fixed)
RESOLVED
FIXED
2.2 S7 (6mar)
People
(Reporter: dietrich, Assigned: cwiiis)
References
Details
(Keywords: polish, Whiteboard: [systemsfe])
Attachments
(1 file)
(deleted),
text/x-github-pull-request
|
mikehenrty
:
review+
tif
:
ui-review+
bajaj
:
approval-gaia-v2.2+
|
Details |
I think I filed this already sometime in the last two years, but cannot find it :(
The transient banners that can appear across the top of the screen last just long enough to be terribly annoying.
Comment 1•11 years ago
|
||
You mean the one that comes from notifications?
Remember they are tappable too. But maybe they're not so useful...
Reporter | ||
Comment 2•11 years ago
|
||
Yes, I filed this bug because they're open *just* long enough that I find myself sitting and waiting for them to go away so I can use the notification area.
I'll try to record when this happens.
However, I bet it's probably safe to reduce by at least 1/3 of what it is now.
Requesting UX feedback on this change.
Flags: needinfo?(firefoxos-ux-bugzilla)
Comment 3•11 years ago
|
||
Flagging Rob for input.
Flags: needinfo?(firefoxos-ux-bugzilla) → needinfo?(rmacdonald)
Comment 4•11 years ago
|
||
Assigning this to Ying Li, who is going to implement this as a contributor as part of the Open Academy project.
Assignee: nobody → liying2905
Comment 5•11 years ago
|
||
You mean that Ying will do the UX work?
Comment 6•11 years ago
|
||
No, Ying is a back-end developer, not a UX designer. Michael Henretty, Dietrich and I have been working with her. She is one of 14 students in the Open Academy project and we identified this as a bug for her to take prior to semester close.
Comment 7•11 years ago
|
||
Ok, then we still need Rob's input before doing anything here, right?
Comment 8•11 years ago
|
||
Yes, though it can take the form of a comment. It's really just to specify a new duration (but this is why Rob is still flagged).
Reporter | ||
Comment 9•11 years ago
|
||
Any UX team input is great, but not required. Mostly this needs someone to play around with different times and see what feels like it gets in the way vs. being too brief to read.
We have the same problem with both top and bottom banners. (I can't remember what the proper names of these pieces are...)
Comment 10•10 years ago
|
||
Sorry for the long delay but we met as a ux team and discussed this last week. Going forward we're considering a time of 2 seconds. In addition, we're proposing that the banners be translucent and not tappable. This will allow the user to interact with the UI underneath the banner. Again, this is tentative but I thought I'd provide an update. NI me if you have any questions or concerns.
Flags: needinfo?(rmacdonald)
Reporter | ||
Comment 11•10 years ago
|
||
Great, thanks Rob! SOunds like we can move forward w/ the 2sec change, yay.
Assignee | ||
Comment 12•10 years ago
|
||
One character change, taking.
Assignee: liying2905 → chrislord.net
Status: NEW → ASSIGNED
Comment 13•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Attachment #8567203 -
Flags: review?(mhenretty)
Comment 14•10 years ago
|
||
Comment on attachment 8567203 [details]
[gaia] Cwiiis:bug988530-notification-toaster-timeout > mozilla-b2g:master
This seems a tad short to me, but definitely a hug improvement over 5 seconds(?!?). Let's get Rob's feedback on this change.
Attachment #8567203 -
Flags: ui-review?(rmacdonald)
Attachment #8567203 -
Flags: review?(mhenretty)
Attachment #8567203 -
Flags: review+
Comment 15•10 years ago
|
||
Please, not too short, I love being able to tap them while they're showing up...
However I could like a shorter status banner lifetime (the one that appears at the bottom).
Comment 16•10 years ago
|
||
How long would you say is good? This patch changes it from 5 seconds to 2 seconds.
Flags: needinfo?(felash)
Comment 17•10 years ago
|
||
I tried various values, and 3500ms seems to be just good for me with the current CSS.
Don't forget that there is a show animation that takes a long time (1.2 + .2 = 1.4sec). Maybe that animation could be made shorter, and in that case we could lower the timeout a little more.
In the animation itself, I especially don't really like the long pause in the middle of the animation. To me it looks like the phone is lagging. So maybe we can shorten this pause and use a timeout of 3000ms.
Flags: needinfo?(felash)
Assignee | ||
Comment 18•10 years ago
|
||
Comment on attachment 8567203 [details]
[gaia] Cwiiis:bug988530-notification-toaster-timeout > mozilla-b2g:master
Changed the delay to 3.5s given last comment, moving ui-review over to tif.
Attachment #8567203 -
Flags: ui-review?(rmacdonald) → ui-review?(tshakespeare)
Comment 19•10 years ago
|
||
Comment on attachment 8567203 [details]
[gaia] Cwiiis:bug988530-notification-toaster-timeout > mozilla-b2g:master
This feels much better. Thanks!!
Attachment #8567203 -
Flags: ui-review?(tshakespeare) → ui-review+
Comment 20•10 years ago
|
||
TIffanie, what do you think about my comment about the animation itself ? (see comment 17)
Flags: needinfo?(tshakespeare)
Assignee | ||
Comment 21•10 years ago
|
||
Marking checkin-needed, we can open another bug if we want to tweak the animation itself.
Keywords: checkin-needed
Updated•10 years ago
|
Keywords: checkin-needed
Comment 22•10 years ago
|
||
Autolander could not locate a review from a user within the suggested reviewer list. Either the patch author or the reviewer should be in the suggested reviewer list.
Assignee | ||
Comment 23•10 years ago
|
||
Sorry autolander, I've not got time for that nonsense for a 2-char change :) Merged: https://github.com/mozilla-b2g/gaia/commit/607db45178703abaa4fba25c3b230e18a1c44f58
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 24•10 years ago
|
||
Comment on attachment 8567203 [details]
[gaia] Cwiiis:bug988530-notification-toaster-timeout > mozilla-b2g:master
[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: Notification toaster covers important UI elements and stays for an unnecessary length of time.
[Testing completed]: Tested locally
[Risk to taking this patch] (and alternatives if risky): Pretty much zero.
[String changes made]: None
Attachment #8567203 -
Flags: approval-gaia-v2.2?
Comment 25•10 years ago
|
||
julien - is that animation actually the "pause" you see before actually showing the notification? I thought that was my phone lagging, but now re-reading your comment I see that it might be an animation of 1.4 seconds? Can you open a bug for this one and we can hopefully make it better? Thanks!
Flags: needinfo?(tshakespeare)
Updated•10 years ago
|
Comment 26•10 years ago
|
||
Done => bug 1137613. Thanks !
Comment 27•10 years ago
|
||
I am approving given the super low risk patch here, but please note we are limiting changes on 2.2 at this point and will no longer be approving non-blockers to help converge and stabilize in the next few weeks.
Updated•10 years ago
|
Attachment #8567203 -
Flags: approval-gaia-v2.2? → approval-gaia-v2.2+
Comment 28•10 years ago
|
||
Updated•10 years ago
|
Whiteboard: [systemsfe]
You need to log in
before you can comment on or make changes to this bug.
Description
•