Closed
Bug 988680
Opened 11 years ago
Closed 9 years ago
Clean up our CSS font-sizes
Categories
(Marketplace Graveyard :: Code Quality, defect, P3)
Tracking
(Not tracked)
RESOLVED
WONTFIX
People
(Reporter: cvan, Unassigned)
References
()
Details
(Keywords: perf, Whiteboard: [marketplace-transition])
http://www.cssstats.com/#/site/url/https%253A%252F%252Fmarketplace.firefox.com
FONT SIZES
All (59) | Unique (19)
font-size: .5em
The quick brown fox jumps over the lazy dog is by far my most favorite pangram in the english language. What is yours?
font-size: 11px
The quick brown fox jumps over the lazy dog is by far my most favorite pangram in the english language. What is yours?
font-size: 75%
The quick brown fox jumps over the lazy dog is by far my most favorite pangram in the english language. What is yours?
font-size: 12px
The quick brown fox jumps over the lazy dog is by far my most favorite pangram in the english language. What is yours?
font-size: 13px
The quick brown fox jumps over the lazy dog is by far my most favorite pangram in the english language. What is yours?
font-size: .83em
The quick brown fox jumps over the lazy dog is by far my most favorite pangram in the english language. What is yours?
font-size: 14px
The quick brown fox jumps over the lazy dog is by far my most favorite pangram in the english language. What is yours?
font-size: 15px
The quick brown fox jumps over the lazy dog is by far my most favorite pangram in the english language. What is yours?
font-size: 16px
The quick brown fox jumps over the lazy dog is by far my most favorite pangram in the english language. What is yours?
font-size: 1em
The quick brown fox jumps over the lazy dog is by far my most favorite pangram in the english language. What is yours?
font-size: 100%
The quick brown fox jumps over the lazy dog is by far my most favorite pangram in the english language. What is yours?
font-size: 18px
The quick brown fox jumps over the lazy dog is by far my most favorite pangram in the english language. What is yours?
font-size: 20px
The quick brown fox jumps over the lazy dog is by far my most favorite pangram in the english language. What is yours?
font-size: 24px
The quick brown fox jumps over the lazy dog is by far my most favorite pangram in the english language. What is yours?
font-size: 30px
The quick brown fox jumps over the lazy dog is by far my most favorite pangram in the english language. What is yours?
font-size: 32px
The quick brown fox jumps over the lazy dog is by far my most favorite pangram in the english language. What is yours?
font-size: 40px
The quick brown fox jumps over the lazy dog is by far my most favorite pangram in the english language. What is yours?
font-size: 100px
Updated•11 years ago
|
Blocks: tarako-marketplace
Updated•11 years ago
|
No longer blocks: tarako-marketplace
Updated•11 years ago
|
Priority: -- → P3
Updated•10 years ago
|
Blocks: marketplace-perf
Is this bug still open and if so could someone explain what needs to be done with the CSS font sizes?
Comment 2•9 years ago
|
||
is this bug stil open i want to work on this bug
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
Whiteboard: [marketplace-transition]
I am still interested in working on this bug but would like a little clarification.
Do you just require some tidying up (grouping styles) or would you like all font sizes changed to one format e.g. ems/rem/px/%?
Comment 4•9 years ago
|
||
(In reply to Ally from comment #3)
> I am still interested in working on this bug but would like a little
> clarification.
> Do you just require some tidying up (grouping styles) or would you like all
> font sizes changed to one format e.g. ems/rem/px/%?
It's a non-finite bug. The original context was that we had too much (one might argue needless) slight variations -- and thus redundancy, or close to it -- in our CSS. But short of complete re-writes, it's not necessarily a good use of time. If the intended design has settled (and it has), then in theory you could simplify the CSS and markup so that it's as compact/minimal as possible. This in theory helps improve download and performance in general, but given traffic and caching I doubt this would really make a lot of difference.
Because we don't want to change any of the design, if this is just about consolidating to ems/rem/px/% (for example), then it's feasible, but I still question if it's worth it.
That said, there are and will be some front-end things we need, both in the whiteboard [good first bug] (or [good_first_bug]) and not, so you might want to look there for things that are more concrete.
You need to log in
before you can comment on or make changes to this bug.
Description
•