http://mxr.mozilla.org/mozilla-central/source/gfx/layers/ipc/AsyncPanZoomController.cpp#1491 is one example. Other uses should be audited.

This'll do for now but I'm going to file a follow-up bug to replace the use of FrameMetrics on the repaint code path with a different struct.

Filed bug 991515 for that.

Not worth figuring out what the corrent thing to pass here is right now.

Not too happy that we compute the rect even if we're not compiling with rendertrace enabled. Any C++ tricks that would make this nicer without #ifdef'ing stuff? I'm hoping the compiler might just optimize it away after inlining LogRendertraceRect but I don't know that it will since.

(In reply to Kartikaya Gupta (email:kats@mozilla.com) from comment #5) > Not too happy that we compute the rect even if we're not compiling with > rendertrace enabled. Any C++ tricks that would make this nicer without > #ifdef'ing stuff? I'm hoping the compiler might just optimize it away after > inlining LogRendertraceRect but I don't know that it will since. CSSRect GetDisplayPortRect() { CSSRect baseRect(...); baseRect.Inflate(...); return baseRect; } ... LogRendertraceRect(GetGuid(), "requested displayport", "yellow", GetDisplayPortRect());

Updated, carrying r+

remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/86cbe44bf63e remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/1eae92bff6d5 remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/c4e120d007fe remote: https://hg.mozilla.org/integration/mozilla-inbound/rev/8013177c1e26

https://hg.mozilla.org/mozilla-central/rev/86cbe44bf63e https://hg.mozilla.org/mozilla-central/rev/1eae92bff6d5 https://hg.mozilla.org/mozilla-central/rev/c4e120d007fe https://hg.mozilla.org/mozilla-central/rev/8013177c1e26

Comment on attachment 8401129 [details] [diff] [review] Patch [Approval Request Comment] Bug caused by (feature/regressing bug #): bug 957668 User impact if declined: things may be painted incorrectly at times. no specific STR but this is a follow-up patch for bug 957668 Testing completed (on m-c, etc.): on m-c Risk to taking this patch (and alternatives if risky): low-risk String or IDL/UUID changes made by this patch: none

https://hg.mozilla.org/releases/mozilla-aurora/rev/b9ec1d22e27b https://hg.mozilla.org/releases/mozilla-aurora/rev/c6de66ddc937 https://hg.mozilla.org/releases/mozilla-aurora/rev/f2cf3e662305 https://hg.mozilla.org/releases/mozilla-aurora/rev/39c47f6896b5

Bustage fix: https://hg.mozilla.org/releases/mozilla-aurora/rev/9c2b0a1b2b17 /me crosses fingers

That didn't quite fix it. Backed out for now since I can't watch the tree much more. Will reland on Monday. https://hg.mozilla.org/releases/mozilla-aurora/rev/cf8120f81e28

Got a green try run with some rebasing: https://tbpl.mozilla.org/?tree=Try&rev=2b2723cc9f5f and relanded on aurora: remote: https://hg.mozilla.org/releases/mozilla-aurora/rev/c5204996e420 remote: https://hg.mozilla.org/releases/mozilla-aurora/rev/65a7823d69df remote: https://hg.mozilla.org/releases/mozilla-aurora/rev/86d484d7fc28 remote: https://hg.mozilla.org/releases/mozilla-aurora/rev/633c0420e98f