Closed Bug 989192 Opened 11 years ago Closed 9 years ago

Create portal detection events on network topology changes and user login

Categories

(Firefox :: Address Bar, enhancement, P2)

enhancement

Tracking

()

RESOLVED WORKSFORME

People

(Reporter: jboriss, Assigned: nhnt11)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxprivacy])

Attachments

(1 file)

As part of Firefox's Captive Portal Design, this bug creates a captive portal detection event on network topology changes and on user login to a captive portal. Firefox captive portal detection should assume the user may authenticate with a captive portal outside of Firefox (e.g other browser, or system interaction). It should attempt to update the captive portal state as best as it can in these scenarios and hide any captive portal UI elements once the user is not behind a captive portal anymore. More information on detection needed for OSX and Windows: https://github.com/vtsatskin/FX-Captive-Portals-Design/blob/master/detection.md Note: Implementation followup from design Bug 878566 Whole Captive Portal Spec: https://github.com/vtsatskin/FX-Captive-Portals-Design/blob/master/design/spec.md
Depends on: 878566
Flags: firefox-backlog?
Flags: firefox-backlog? → firefox-backlog+
No longer blocks: fxdesktopbacklog
Whiteboard: p=0
Flags: firefox-backlog+ → firefox-backlog-
Whiteboard: p=0
Blocks: 1202680
Priority: -- → P3
Whiteboard: [fxprivacy]
Flags: firefox-backlog- → qe-verify?
Priority: P3 → P2
Attached patch WIP (deleted) — Splinter Review
I threw together a basic WIP today. This uses XHR to try and detect a captive portal, based on https://www.chromium.org/chromium-os/chromiumos-design-docs/network-portal-detection. TODO: 1. We probably want our own "test page" (maybe an existing one, maybe a new one). I'm piggybacking on Google for now. 2. Some sort of state object needs to be implemented with an API. 3. I haven't implemented login detection yet. I suspect that once we know there's a captive portal, we can watch for successful requests to URLs other than the captive portal one, and then re-test and update state.
Assignee: nobody → nhnt11
Status: NEW → ASSIGNED
Hey Nihanth, you may want to look at https://mxr.mozilla.org/mozilla-central/source/toolkit/components/captivedetect/ if you haven't already. We already have a detection endpoint for FxOS that you can probably use. I think Valentin Gosu may have some other code for captive portals too.
A large part of this is already implemented in the code Matt linked to and bug 1048131 implements a captive portal detection service.
The events are already generated in captivedetect.js linked above. Closing this bug.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: