Alison Shiue Reporter
	Description • 11 years ago

### ENV
Buri/Bluez
[1] https://pvtbuilds.mozilla.org/pvt/mozilla.org/b2gotoro/nightly/mozilla-aurora-hamachi-eng/2014/03/2014-03-25-16-02-01/


### STR
1. PTS 5.0
2. TC_AG_IAC_BV_01_I

### Expected
Pass 

### Actual
Failed

	Ben Tian (inactive) Assignee
	Comment 1 • 11 years ago

The failure cause is that dialer app connects SCO before answering incoming call. SCO should not be connected until the incoming call is answered.

ni? gaia team Arthur. Arthur, can you check dialer's call answering behavior?

	Ben Tian (inactive) Assignee
	Comment 2 • 11 years ago

ni? Rex instead as Arthur is busy on other bugs.

	KM Lee [:rexboy] (inactivate after Sep. 22)
	Comment 3 • 11 years ago

A quick fix that I can come up. Just did some easy test and it seems to be ok.
I would suggest testing it by tapping the audio source button on call screen, switching audio output between phone receiver/rear phone speaker/ and BT headphone.

Sorry for not available coming up a full patch. If you can't find someone finishing this you can ping me again.

	Ben Tian (inactive) Assignee
	Comment 4 • 11 years ago

Rex, please feedback on my patch.

The patch removes SCO connecting for first incoming/outgoing call since 1) SCO should not be connected until user answers incoming call and 2) for outgoing call, gecko bluetooth connects SCO automatically.

I also wonder whether [1] should change as well. What's the default audio output if both headphone and BT headset are connected?

[1] https://github.com/mozilla-b2g/gaia/pull/15032/files#diff-d92153efec08c1bd2eb8540c4a6a8c31R89

	KM Lee [:rexboy] (inactivate after Sep. 22)
	Comment 5 • 11 years ago

Comment on attachment 8400357 [details]
link to https://github.com/mozilla-b2g/gaia/pull/17865

Seems ok to me.
we need to add unit tests for check-in the code though.

	Ben Tian (inactive) Assignee
	Comment 6 • 11 years ago

Comment on attachment 8400357 [details]
link to https://github.com/mozilla-b2g/gaia/pull/17865

Updated PR and added unit test.

The new patch adds a boolean |connectBtSco| to control whether |switchToDefaultOut| connects BT SCO or not. Two conditions not to connect SCO: 1) first incoming/outgoing call and 2) headphone plugged in.

The reason for 1) is that bluetooth certification test requires SCO be connected AFTER user answers incoming call, and gecko would connect SCO automatically after user answers incoming call or dials outgoing call. The reason for 2) is that headphone plugging in should not trigger BT SCO connection.

Etienne, can you help review my PR?

	Etienne Segonzac (:etienne)
	Comment 10 • 11 years ago

Comment on attachment 8400357 [details]
link to https://github.com/mozilla-b2g/gaia/pull/17865

Thanks for the tests, it's in good shape, a few comments:

* lets switch to a |doNotConnect| optional parameter, this way we'll only need to pass an argument for the first incoming call case

* bonus: you can do something like |CallScreen.switchToDefaultOut(true /* do not connect */);| to make it extra readable

* the switchToDefaultOut function will do a |if (!doNotConnect)|


* we need to add a small test to call_screen_test.js making sure we're passing the argument along properly

Cheers!

	Ben Tian (inactive) Assignee
	Comment 11 • 11 years ago

Comment on attachment 8400357 [details]
link to https://github.com/mozilla-b2g/gaia/pull/17865

Updated PR based on reviewer's comment.

	Etienne Segonzac (:etienne)
	Comment 12 • 11 years ago

Comment on attachment 8400357 [details]
link to https://github.com/mozilla-b2g/gaia/pull/17865

Thanks Ben, r=me with the comments addressed.

	Ben Tian (inactive) Assignee
	Comment 13 • 11 years ago

Thanks Etienne. I've revised the nits and merged the PR to gaia master.
https://github.com/mozilla-b2g/gaia/commit/c858ccb62e755dafe252908c75815f84e22f2f76

	Ben Tian (inactive) Assignee
	Comment 14 • 11 years ago

Set 1.4? since this bug fails bluetooth certification HSP test case TC_AG_IAC_BV_01_I.

	Preeti Raghunath(:Preeti)
	Comment 15 • 11 years ago

Likely BT IOT failure. Hence blocking

	Ben Tian (inactive) Assignee
	Comment 16 • 11 years ago

Fixed in gaia master. Require uplift to v1.4 branch.

	Ryan VanderMeulen [:RyanVM]
	Comment 17 • 11 years ago

v1.4: https://github.com/mozilla-b2g/gaia/commit/80240586ccb5b3c5ad4b8928a6f32fd7ad1456f8

FWIW, we have needs-uplift queries that are triaged regularly, so you don't need to checkin-needed them :)

	Alison Shiue Reporter
	Comment 18 • 11 years ago

Verified on
Gaia      d23e479e8a4ce0bc620acb2d7e2f82801aa4d0ea
Gecko     https://hg.mozilla.org/releases/mozilla-aurora/rev/36f67ce46855
BuildID   20140428000206
Version   30.0a2