Nicolas Perriault (:NiKo`) — needinfo me if you need my attention Reporter
	Description • 11 years ago

In talkilla we used Blanket (http://blanketjs.org/) with great results.

	:shell escalante
	Comment 1 • 10 years ago

can you give a more detailed description on what this would take, how important is it?  Just how big?

	Nicolas Perriault (:NiKo`) — needinfo me if you need my attention Reporter
	Comment 2 • 10 years ago

I wrote a lengthy blog post about code coverage, it's probably worth reading https://nicolas.perriault.net/code/2013/get-your-frontend-javascript-code-covered/

> what this would take

Integrating blanket to our unit tests suites.

> how important is it?

I think it's fairly important as it can help identifying possible problems before they ship to production.

> Just how big?

Shouldn't take too much energy as blanket is an already made, battle proof open source project with compatible licensing. It shouldn't be more than 5 points.

	:shell escalante
	Comment 3 • 10 years ago

thanks Niko.  loved the blog post - based on the reward to effort.. P2 in 37.  meaning we wouldn't block 37 and we have to take the P1's and earlier release patches first... but when P1's gone or you are blocked/brainfried - it's on the pull list.

	Mark Banner (:standard8)
	Comment 4 • 10 years ago

The only downside, is that blanket requires node. We could probably do this for loop-client as a first step, but wouldn't be able to do any requirements for checkin based on unit tests until we had the node dependency in our tests.

	Mark Banner (:standard8)
	Comment 5 • 10 years ago

Also, xref bug 890116 - where code coverage is actively being worked on to add it to the tree for everyone not just Loop, so we might just get it for free there.

	Nicolas Perriault (:NiKo`) — needinfo me if you need my attention Reporter
	Comment 6 • 10 years ago

(In reply to Mark Banner (:standard8) from comment #4)
> The only downside, is that blanket requires node. 

Nope, there's a dist version of it (the same we used for talkilla browser tests) https://raw.githubusercontent.com/alex-seville/blanket/master/dist/qunit/blanket.min.js

(In reply to Mark Banner (:standard8) from comment #5)
> Also, xref bug 890116 - where code coverage is actively being worked on to
> add it to the tree for everyone not just Loop, so we might just get it for
> free there.

How would that work for our content-based tests (mocha & friends)?

	Mark Banner (:standard8)
	Comment 7 • 9 years ago

Bug 1183884 has enabled coverage for at least the manual case. I'm going to close this bug as a duplicate of that one.

When we want to add more infra for automation or whatever, we can file specific bugs on those.