Closed Bug 989288 Opened 11 years ago Closed 9 years ago

Firefox Addons SDK is not receving any events from windows opened via window.open

Categories

(Add-on SDK Graveyard :: General, defect, P1)

defect

Tracking

(firefox46 fixed)

RESOLVED FIXED
mozilla46
Tracking Status
firefox46 --- fixed

People

(Reporter: alagiriforjob, Unassigned)

References

Details

Attachments

(1 file)

User Agent: Mozilla/5.0 (Windows NT 6.1) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/33.0.1750.154 Safari/537.36 Steps to reproduce: 1.created a sample html page which contains window.open 2.I created an Add-on SDK to listen window,tab and page-mod events 3.Check for window , tab and page-mod events for newly opened window using window.open. Actual results: Events in the newly created window via window.open is not listened from add-on sdk Expected results: We should be able to receive window , tab and page-mod events from newly created window.
Still the case in Firefox 40. We're receiving absolutely no events from these windows.
Additionally, I noticed the following behaviors: 1) When attaching a content script via the onAttach method of a pagemod config, when the specified callback function is called the worker delivered via its parameter does not have a tab (worker.tab is undefined) 2) No events are fired when the window is opened, but as soon as its _closed_, the following events are immediately received: browserTabs.on("open") browserTabs.on("close") browserWindows.on("close") Maybe that helps.
The pull request on bug #939496, closely related with this one, has been updated. Please review, thanks!
The pull request for this bug has been updated, reviews are welcome. If the preferred way to contribute code has changed lately, I can send the patch by any other means. Thanks!
Any chance to get the patch reviewed? Thanks in advance!
Comment on attachment 8648120 [details] Pull request with a fix and tests for this bug. From r? comments in https://github.com/mozilla/addon-sdk/pull/2030#issuecomment-163801394
Attachment #8648120 - Flags: review?(zer0)
Hi, any chance to get the patch reviewed? Thanks!
Can we please get this reviewed? Thanks!
Ping Matteo for r?
Comment on attachment 8648120 [details] Pull request with a fix and tests for this bug. Sorry for the long waiting. Looks good to me, r+. I ran the test suite against this patch and seems there are no failures, at least locally.
Attachment #8648120 - Flags: review?(zer0) → review+
Status: UNCONFIRMED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Status: RESOLVED → UNCONFIRMED
Resolution: FIXED → ---
Status: UNCONFIRMED → RESOLVED
Closed: 9 years ago9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: