Closed Bug 989331 Opened 11 years ago Closed 11 years ago

Implement fireplace-specific collection endpoint/serializer

Categories

(Marketplace Graveyard :: API, defect, P1)

x86_64
Linux
defect

Tracking

(Not tracked)

RESOLVED FIXED
2014-04-15

People

(Reporter: mat, Assigned: mat)

References

Details

(Keywords: perf, Whiteboard: [qa-])

Fireplace uses /rocketfuel/collections/ and /fireplace/search/featured/ endpoints when dealing with collections. Both use the default CollectionSerializer, which returns a bunch of data Fireplace doesn't need, we should have a fireplace-specific one. Also, this serializer uses SimpleAppSerializer and SimpleESAppSerializer, so for apps inside a collection we also return some info that fireplace doesn't need. The new, fireplace-specific Collection serializer should use FireplaceAppSerializer and FireplaceESAppSerializer to further reduce the amount of information sent to fireplace.
Status: NEW → ASSIGNED
Target Milestone: --- → 2014-04-08
Blocks: 989397
Because we want to avoid duplicating endpoints all the time, I'm making this bug depend on bug 989397. I moved the second part of comment 0, which we can easily implement right now (in fact I already have a PR for it), to a separate bug, bug 989405.
No longer blocks: 989397
Status: ASSIGNED → NEW
Depends on: 989397
Target Milestone: 2014-04-08 → ---
bug 989405 will give us perf improvements on the homepage, the remaining stuff for this one won't, since it's only /rocketfuel/collections/, which is only used when the user clicks on a collection. Downgrading priority as a result.
Priority: P2 → P4
No longer blocks: tarako-marketplace
Blocks: 992365
This is actually going to be more important to tarako, if we keep the approach described in https://github.com/cvan/metropolis/wiki/Technical-Architecture#database - Currently, metropolis uses /rocketfuel/collections/curated/, which 1) doesn't use ES for apps and 2) returns extra data about apps that we don't care about
Priority: P4 → P1
Status: NEW → ASSIGNED
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [qa-]
Target Milestone: --- → 2014-04-15
You need to log in before you can comment on or make changes to this bug.